colo: Don't dump colo cache if dump-guest-core=off

One might set dump-guest-core=off to make coredumps smaller and
still allow to debug many qemu bugs. Extend this option to the colo
cache.

Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
This commit is contained in:
Lukas Straub 2021-07-04 18:14:44 +02:00 committed by Juan Quintela
parent 2b9f6bf36c
commit e5fdf92096
1 changed files with 6 additions and 0 deletions

View File

@ -56,6 +56,8 @@
#include "multifd.h"
#include "sysemu/runstate.h"
#include "hw/boards.h" /* for machine_dump_guest_core() */
#if defined(__linux__)
#include "qemu/userfaultfd.h"
#endif /* defined(__linux__) */
@ -3542,6 +3544,10 @@ int colo_init_ram_cache(void)
}
return -errno;
}
if (!machine_dump_guest_core(current_machine)) {
qemu_madvise(block->colo_cache, block->used_length,
QEMU_MADV_DONTDUMP);
}
}
}