OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

hw/audio/hda-codec: reenable the audio mixer

Browse Source 
Commit b7639b7dd0 ("hw/audio: Simplify hda audio init") inverted
the sense of hda codec property mixer during initialization.
Change the code so that mixer=on enables the hda mixer emulation
and mixer=off disables the hda mixer emulation.

With this change audio playback and recording streams don't start
muted by default.

Fixes: b7639b7dd0 ("hw/audio: Simplify hda audio init")
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-Id: <20231105172552.8405-2-vr_qemu@t-online.de>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This commit is contained in:
Volker Rümelin 2023-11-05 18:25:52 +01:00 committed by Michael S. Tsirkin
parent 74e8593e7e
commit e60bdfb78e
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
hw/audio/hda-codec.c
View File

@ -868,10 +868,10 @@ static Property hda_audio_properties[] = {
static void hda_audio_init_output(HDACodecDevice *hda, Error **errp)
{
HDAAudioState *a = HDA_AUDIO(hda);
const struct desc_codec *desc = &output_nomixemu;
const struct desc_codec *desc = &output_mixemu;
if (!a->mixer) {
desc = &output_mixemu;
desc = &output_nomixemu;
}
hda_audio_init(hda, desc, errp);
@ -880,10 +880,10 @@ static void hda_audio_init_output(HDACodecDevice *hda, Error **errp)
static void hda_audio_init_duplex(HDACodecDevice *hda, Error **errp)
{
HDAAudioState *a = HDA_AUDIO(hda);
const struct desc_codec *desc = &duplex_nomixemu;
const struct desc_codec *desc = &duplex_mixemu;
if (!a->mixer) {
desc = &duplex_mixemu;
desc = &duplex_nomixemu;
}
hda_audio_init(hda, desc, errp);
@ -892,10 +892,10 @@ static void hda_audio_init_duplex(HDACodecDevice *hda, Error **errp)
static void hda_audio_init_micro(HDACodecDevice *hda, Error **errp)
{
HDAAudioState *a = HDA_AUDIO(hda);
const struct desc_codec *desc = &micro_nomixemu;
const struct desc_codec *desc = &micro_mixemu;
if (!a->mixer) {
desc = &micro_mixemu;
desc = &micro_nomixemu;
}
hda_audio_init(hda, desc, errp);