From e932e9f327650d4a3f745539e8c4bf4f72a08015 Mon Sep 17 00:00:00 2001 From: Mauro Matteo Cascella Date: Thu, 20 May 2021 12:58:33 +0200 Subject: [PATCH] ui/spice-display: check NULL pointer in interface_release_resource() Check rext.info to avoid potential NULL pointer dereference. A similar check exists in interface_release_resource() in hw/display/qxl.c. Reported-by: Yu Lu Signed-off-by: Mauro Matteo Cascella Reviewed-by: Prasad J Pandit Message-Id: <20210520105833.183160-1-mcascell@redhat.com> Signed-off-by: Gerd Hoffmann --- ui/spice-display.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ui/spice-display.c b/ui/spice-display.c index d22781a23d..f59c69882d 100644 --- a/ui/spice-display.c +++ b/ui/spice-display.c @@ -561,6 +561,10 @@ static void interface_release_resource(QXLInstance *sin, SimpleSpiceCursor *cursor; QXLCommandExt *ext; + if (!rext.info) { + return; + } + ext = (void *)(intptr_t)(rext.info->id); switch (ext->cmd.type) { case QXL_CMD_DRAW: