target/arm: Simplify op_smlaxxx for SMLAL*

Since all of the inputs and outputs are i32, dispense with
the intermediate promotion to i64 and use tcg_gen_add2_i32.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20190904193059.26202-11-richard.henderson@linaro.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
This commit is contained in:
Richard Henderson 2019-09-04 12:30:00 -07:00 committed by Peter Maydell
parent 26c6923de7
commit ea96b37464

View File

@ -8177,8 +8177,7 @@ DO_QADDSUB(QDSUB, false, true)
static bool op_smlaxxx(DisasContext *s, arg_rrrr *a, static bool op_smlaxxx(DisasContext *s, arg_rrrr *a,
int add_long, bool nt, bool mt) int add_long, bool nt, bool mt)
{ {
TCGv_i32 t0, t1; TCGv_i32 t0, t1, tl, th;
TCGv_i64 t64;
if (s->thumb if (s->thumb
? !arm_dc_feature(s, ARM_FEATURE_THUMB_DSP) ? !arm_dc_feature(s, ARM_FEATURE_THUMB_DSP)
@ -8202,12 +8201,14 @@ static bool op_smlaxxx(DisasContext *s, arg_rrrr *a,
store_reg(s, a->rd, t0); store_reg(s, a->rd, t0);
break; break;
case 2: case 2:
t64 = tcg_temp_new_i64(); tl = load_reg(s, a->ra);
tcg_gen_ext_i32_i64(t64, t0); th = load_reg(s, a->rd);
t1 = tcg_const_i32(0);
tcg_gen_add2_i32(tl, th, tl, th, t0, t1);
tcg_temp_free_i32(t0); tcg_temp_free_i32(t0);
gen_addq(s, t64, a->ra, a->rd); tcg_temp_free_i32(t1);
gen_storeq_reg(s, a->ra, a->rd, t64); store_reg(s, a->ra, tl);
tcg_temp_free_i64(t64); store_reg(s, a->rd, th);
break; break;
default: default:
g_assert_not_reached(); g_assert_not_reached();