linux-user: sigprocmask check read perms first
Linux kernel now checks the read permissions before validating `how` Suggested-by: Laurent Vivier <laurent@vivier.eu> Signed-off-by: Patrick Venture <venture@google.com> Reviewed-by: Laurent Vivier <laurent@vivier.eu> Message-Id: <20220126212559.1936290-3-venture@google.com> [lv: remove unneeded ")"] Signed-off-by: Laurent Vivier <laurent@vivier.eu>
This commit is contained in:
parent
d3ced2a59a
commit
ebce1719ac
|
@ -9435,6 +9435,13 @@ static abi_long do_syscall1(void *cpu_env, int num, abi_long arg1,
|
||||||
int how;
|
int how;
|
||||||
|
|
||||||
if (arg2) {
|
if (arg2) {
|
||||||
|
p = lock_user(VERIFY_READ, arg2, sizeof(target_sigset_t), 1);
|
||||||
|
if (!p) {
|
||||||
|
return -TARGET_EFAULT;
|
||||||
|
}
|
||||||
|
target_to_host_old_sigset(&set, p);
|
||||||
|
unlock_user(p, arg2, 0);
|
||||||
|
set_ptr = &set;
|
||||||
switch (arg1) {
|
switch (arg1) {
|
||||||
case TARGET_SIG_BLOCK:
|
case TARGET_SIG_BLOCK:
|
||||||
how = SIG_BLOCK;
|
how = SIG_BLOCK;
|
||||||
|
@ -9448,11 +9455,6 @@ static abi_long do_syscall1(void *cpu_env, int num, abi_long arg1,
|
||||||
default:
|
default:
|
||||||
return -TARGET_EINVAL;
|
return -TARGET_EINVAL;
|
||||||
}
|
}
|
||||||
if (!(p = lock_user(VERIFY_READ, arg2, sizeof(target_sigset_t), 1)))
|
|
||||||
return -TARGET_EFAULT;
|
|
||||||
target_to_host_old_sigset(&set, p);
|
|
||||||
unlock_user(p, arg2, 0);
|
|
||||||
set_ptr = &set;
|
|
||||||
} else {
|
} else {
|
||||||
how = 0;
|
how = 0;
|
||||||
set_ptr = NULL;
|
set_ptr = NULL;
|
||||||
|
|
Loading…
Reference in New Issue