OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

usb-storage: fix possible memory leak and missing error message

Browse Source 
When scsi_bus_legacy_add_drive() return NULL, meanwhile err will
be not NULL, which will casue memory leak and missing error message.

Cc: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
This commit is contained in:
Gonglei 2014-09-19 14:48:23 +08:00 committed by Gerd Hoffmann
parent 31376776d0
commit f0bc7fe3b7
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hw/usb/dev-storage.c
View File

@ -624,6 +624,8 @@ static int usb_msd_initfn_storage(USBDevice *dev)
s->conf.bootindex, dev->serial, s->conf.bootindex, dev->serial,
&err); &err);
if (!scsi_dev) { if (!scsi_dev) {
error_report("%s", error_get_pretty(err));
error_free(err);
return -1; return -1;
} }
s->bus.qbus.allow_hotplug = 0; s->bus.qbus.allow_hotplug = 0;