From f454f49c42d4ec7bdbbb5a7d9c0c8bfb24b28ca4 Mon Sep 17 00:00:00 2001 From: Gonglei Date: Thu, 12 May 2016 17:57:07 +0800 Subject: [PATCH] egl-helpers: fix possible resource leak CID 1352419, using g_strdup_printf instead of asprintf. Signed-off-by: Gonglei Reviewed-by: Paolo Bonzini Message-id: 1463047028-123868-2-git-send-email-arei.gonglei@huawei.com Signed-off-by: Gerd Hoffmann --- ui/egl-helpers.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/ui/egl-helpers.c b/ui/egl-helpers.c index 558edfdeb7..22835c0626 100644 --- a/ui/egl-helpers.c +++ b/ui/egl-helpers.c @@ -49,18 +49,15 @@ int qemu_egl_rendernode_open(void) continue; } - r = asprintf(&p, "/dev/dri/%s", e->d_name); - if (r < 0) { - return -1; - } + p = g_strdup_printf("/dev/dri/%s", e->d_name); r = open(p, O_RDWR | O_CLOEXEC | O_NOCTTY | O_NONBLOCK); if (r < 0) { - free(p); + g_free(p); continue; } fd = r; - free(p); + g_free(p); break; }