OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

char-pty: remove the check for connection on write

Browse Source 
This doesn't help much compared to the 1 second poll PTY
timer. I can't think of a use case where this would help.

However, we can simplify the code around chr_write(): the write lock
is no longer needed for other char-pty callbacks (see following
patch).

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20190206174328.9736-6-marcandre.lureau@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Marc-André Lureau 2019-02-06 18:43:27 +01:00
parent 64c3f266dd
commit f8278c7d74
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
chardev/char-pty.c
View File

@ -130,11 +130,7 @@ static int char_pty_chr_write(Chardev *chr, const uint8_t *buf, int len)
PtyChardev *s = PTY_CHARDEV(chr); PtyChardev *s = PTY_CHARDEV(chr);
if (!s->connected) { if (!s->connected) {
/* guest sends data, check for (re-)connect */ return len;
pty_chr_update_read_handler_locked(chr);
if (!s->connected) {
return len;
}
} }
return io_channel_send(s->ioc, buf, len); return io_channel_send(s->ioc, buf, len);
} }