OpenE2K
/
qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

qemu-io: Fix warnings from static code analysis 

Smatch complains about several global symbols which should be local.

Add the missing 'static' attributes and move the 'extern' declaration
of variable qemuio_misalign to qemu-io.h. This variable also changes
the type from 'int' to 'bool' which better fits documents its use.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
This commit is contained in:
Stefan Weil 2014-03-05 22:23:00 +01:00 committed by Stefan Hajnoczi
parent 9562f69cfd
commit f988388025
3 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/qemu-io.h
View File

@ -38,6 +38,8 @@ typedef struct cmdinfo {
helpfunc_t help;
} cmdinfo_t;
extern bool qemuio_misalign;
bool qemuio_command(BlockDriverState *bs, const char *cmd);
void qemuio_add_command(const cmdinfo_t *ci);

2
qemu-io-cmds.c
View File

@ -16,7 +16,7 @@
#define CMD_NOFILE_OK 0x01
int qemuio_misalign;
bool qemuio_misalign;
static cmdinfo_t *cmdtab;
static int ncmds;

7
qemu-io.c
View File

@ -24,10 +24,9 @@
#define CMD_NOFILE_OK 0x01
char *progname;
static char *progname;
BlockDriverState *qemuio_bs;
extern int qemuio_misalign;
static BlockDriverState *qemuio_bs;
/* qemu-io commands passed using -c */
static int ncmdline;
@ -408,7 +407,7 @@ int main(int argc, char **argv)
readonly = 1;
break;
case 'm':
qemuio_misalign = 1;
qemuio_misalign = true;
break;
case 'g':
growable = 1;