From fb084237a3b78b20fd9d888dffd673b6656ea3be Mon Sep 17 00:00:00 2001 From: Richard Henderson Date: Tue, 4 Jan 2022 21:14:23 -0800 Subject: [PATCH] common-user: Really fix i386 calls to safe_syscall_set_errno_tail Brown bag time: offset 0 from esp is the return address, offset 4 is the first argument. Fixes: d7478d4229f0 ("common-user: Fix tail calls to safe_syscall_set_errno_tail") Signed-off-by: Richard Henderson --- common-user/host/i386/safe-syscall.inc.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common-user/host/i386/safe-syscall.inc.S b/common-user/host/i386/safe-syscall.inc.S index 9c45e56e48..db2ed09839 100644 --- a/common-user/host/i386/safe-syscall.inc.S +++ b/common-user/host/i386/safe-syscall.inc.S @@ -120,7 +120,7 @@ safe_syscall_end: pop %ebp .cfi_adjust_cfa_offset -4 .cfi_restore ebp - mov %eax, (%esp) + mov %eax, 4(%esp) jmp safe_syscall_set_errno_tail .cfi_endproc