OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

hw/misc/applesmc: Fix memory leak in reset() handler

Browse Source 
AppleSMCData is allocated with g_new0() in applesmc_add_key():
release it with g_free().

Leaked since commit 1ddda5cd36 ("AppleSMC device emulation").

Cc: qemu-stable@nongnu.org
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2272
Reported-by: Zheyu Ma <zheyuma97@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20240408095217.57239-3-philmd@linaro.org>
This commit is contained in:
Philippe Mathieu-Daudé 2024-04-08 11:41:59 +02:00
parent 5c338216f5
commit fc09ff2979
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
hw/misc/applesmc.c
View File

@ -274,6 +274,7 @@ static void qdev_applesmc_isa_reset(DeviceState *dev)
/* Remove existing entries */ /* Remove existing entries */
QLIST_FOREACH_SAFE(d, &s->data_def, node, next) { QLIST_FOREACH_SAFE(d, &s->data_def, node, next) {
QLIST_REMOVE(d, node); QLIST_REMOVE(d, node);
g_free(d);
} }
s->status = 0x00; s->status = 0x00;
s->status_1e = 0x00; s->status_1e = 0x00;