36ebc7db79
The QERR_ macros are leftovers from the days of "rich" error objects.
We've been trying to reduce their remaining use.
qmp_query_vm_generation_id() in stubs/vmgenid.c is the last user of
QERR_UNSUPPORTED outside qga/. Unlike the stubs we just dropped, it
is actually reachable, namely when CONFIG_ACPI_VMGENID is off. It
always fails like
(qemu) info vm-generation-id
Error: this feature or command is not currently supported
Turns out the real qmp_query_vm_generation_id() doesn't actually
depend on CONFIG_ACPI_VMGENID, and fails safely when it's off. Move
it to hw/core/machine-qmp-cmds.c, and drop the stub. The error
message becomes
Error: VM Generation ID device not found
Feels like an improvement to me.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230207075115.1525-8-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Juan Quintela <quintela@redhat.com>
|
||
|---|---|---|
| .. | ||
| bdrv-next-monitor-owned.c | ||
| blk-commit-all.c | ||
| blk-exp-close-all.c | ||
| blockdev-close-all-bdrv-states.c | ||
| change-state-handler.c | ||
| cmos.c | ||
| cpu-get-clock.c | ||
| cpu-synchronize-state.c | ||
| cpus-get-virtual-clock.c | ||
| dump.c | ||
| error-printf.c | ||
| fdset.c | ||
| fw_cfg.c | ||
| gdbstub.c | ||
| get-vm-name.c | ||
| graph-lock.c | ||
| icount.c | ||
| io_uring.c | ||
| iothread-lock-block.c | ||
| iothread-lock.c | ||
| is-daemonized.c | ||
| isa-bus.c | ||
| linux-aio.c | ||
| meson.build | ||
| migr-blocker.c | ||
| module-opts.c | ||
| monitor-core.c | ||
| monitor.c | ||
| pci-bus.c | ||
| physmem.c | ||
| qdev.c | ||
| qemu-timer-notify-cb.c | ||
| qmp_memory_device.c | ||
| qmp-command-available.c | ||
| qmp-quit.c | ||
| qtest.c | ||
| ram-block.c | ||
| ramfb.c | ||
| replay-tools.c | ||
| replay.c | ||
| runstate-check.c | ||
| semihost.c | ||
| sysbus.c | ||
| target-get-monitor-def.c | ||
| target-monitor-defs.c | ||
| trace-control.c | ||
| usb-dev-stub.c | ||
| uuid.c | ||
| vfio-user-obj.c | ||
| vm-stop.c | ||
| vmstate.c | ||
| win32-kbd-hook.c | ||
| xen-hw-stub.c | ||