qemu-e2k

History

Philippe Mathieu-Daudé 5a70b8b550 hw/ipmi: Rewrite a fall through comment

GCC9 is confused by this comment when building with CFLAG
-Wimplicit-fallthrough=2:

  hw/ipmi/ipmi_bmc_extern.c: In function ‘addchar’:
  hw/ipmi/ipmi_bmc_extern.c:178:12: error: this statement may fall through [-Werror=implicit-fallthrough=]
    178 |         ch |= 0x10;
        |         ~~~^~~~~~~
  hw/ipmi/ipmi_bmc_extern.c:181:5: note: here
    181 |     default:
        |     ^~~~~~~
  cc1: all warnings being treated as errors
  make: *** [rules.mak:69: hw/ipmi/ipmi_bmc_extern.o] Error 1

Rewrite the comment using 'fall through' which is recognized by
GCC and static analyzers.

Reported-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Corey Minyard <cminyard@mvista.com>
Message-Id: <20190719131425.10835-5-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>

2019-08-21 10:56:19 +02:00

ipmi_bmc_extern.c

hw/ipmi: Rewrite a fall through comment

2019-08-21 10:56:19 +02:00

ipmi_bmc_sim.c

Include hw/qdev-properties.h less

2019-08-16 13:31:53 +02:00

ipmi.c

sysemu: Split sysemu/runstate.h off sysemu/sysemu.h

2019-08-16 13:37:36 +02:00

isa_ipmi_bt.c

Include hw/qdev-properties.h less