OpenE2K
/
qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity
qemu-e2k/scripts/qapi
History
Markus Armbruster a0c7b99bf7 qapi: Fix crash on missing enum member name 
New test case enum-dict-no-name.json crashes:

    $ python3 scripts/qapi-gen.py tests/qapi-schema/enum-dict-no-name.json
    Traceback (most recent call last):
    [...]
      File "/work/armbru/qemu/scripts/qapi/expr.py", line 458, in check_enum
	member_name = member['name']
    KeyError: 'name'

Root cause: we try to retrieve member 'name' before we check for
missing members.  With that fixed, we get the expected error "'data'
member misses key 'name'".

Fixes: 0825f62c84
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20210616072121.626431-1-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
 		2021-07-15 12:56:41 +02:00
..
.flake8 qapi: delint using flake8 2020-10-10 11:37:47 +02:00
.isort.cfg qapi: enforce import order/styling with isort 2020-10-10 11:37:47 +02:00
__init__.py
…
commands.py qapi: Implement deprecated-input=reject for QMP command arguments 2021-03-19 16:05:11 +01:00
common.py qapi: add must_match helper 2021-05-20 11:28:28 +02:00
error.py qapi/error: Add type hints 2021-04-30 12:59:54 +02:00
events.py qapi: Implement deprecated-output=hide for QMP event data 2021-03-19 15:43:33 +01:00
expr.py qapi: Fix crash on missing enum member name 2021-07-15 12:56:41 +02:00
gen.py qapi: Replace List[str] with Sequence[str] for ifcond 2021-02-18 17:10:29 +01:00
introspect.py qapi/introspect.py: set _gen_tree's default ifcond argument to () 2021-02-18 19:51:14 +01:00
main.py qapi: add must_match helper 2021-05-20 11:28:28 +02:00
mypy.ini qapi/error.py: enable mypy checks 2021-04-30 12:59:54 +02:00
parser.py qapi/parser: add docstrings 2021-05-20 17:10:09 +02:00
pylintrc qapi/parser: allow 'ch' variable name 2021-05-20 17:09:44 +02:00
schema.py qapi/parser: Don't try to handle file errors 2021-05-20 11:28:27 +02:00
source.py qapi/source: Remove line number from QAPISourceInfo initializer 2021-05-20 11:28:27 +02:00
types.py qapi: Replace List[str] with Sequence[str] for ifcond 2021-02-18 17:10:29 +01:00
visit.py qapi: Implement deprecated-input=reject for QMP command arguments 2021-03-19 16:05:11 +01:00