OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity
qemu-e2k/hw/block
History
Markus Armbruster 07a978ef37 fdc: Fix fallback=auto error handling 
fdctrl_realize_common() rejects fallback=auto.  Used by devices
"isa-fdc", "sysbus-fdc", "SUNW,fdtwo".  The error handling is broken:

    $ qemu-system-x86_64 -nodefaults -device isa-fdc,fallback=auto,driveA=fd0 -drive if=none,id=fd0
    **
    ERROR:/work/armbru/qemu/hw/block/fdc.c:434:pick_drive_type: assertion failed: (drv->drive != FLOPPY_DRIVE_TYPE_AUTO)
    Aborted (core dumped)

Cause: fdctrl_realize_common() neglects to bail out after setting the
error.  Fix that.

Fixes: a73275dd6fc3bfda33165bebc28e0c33c20cb0a0
Cc: John Snow <jsnow@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200422130719.28225-7-armbru@redhat.com>
2020-04-29 08:01:52 +02:00
..
dataplane
xen-block: Fix double qlist remove and request leak
2020-04-07 13:51:09 +02:00
block.c
pflash: Require backend size to match device, improve errors
2019-03-26 08:16:24 +01:00
cdrom.c
Include qemu-common.h exactly where needed
2019-06-12 13:20:20 +02:00
ecc.c
Include hw/hw.h exactly where needed
2019-08-16 13:31:52 +02:00
fdc.c
fdc: Fix fallback=auto error handling
2020-04-29 08:01:52 +02:00
hd-geometry.c
block: Remove blk_pread_unthrottled()
2019-08-16 10:25:16 +02:00
Kconfig
hw/m68k: add a dummy SWIM floppy controller
2019-10-28 19:06:51 +01:00
m25p80.c
m25p80: Improve command handling for unsupported commands
2020-03-17 11:36:42 +00:00
Makefile.objs
hw/*/Makefile.objs: Move many .o files to common-objs
2020-02-04 09:00:57 +01:00
nand.c
qdev: set properties with device_class_set_props()
2020-01-24 20:59:15 +01:00
nvme.c
qdev: set properties with device_class_set_props()
2020-01-24 20:59:15 +01:00
nvme.h
nvme: add Get/Set Feature Timestamp support
2019-06-04 15:22:09 +02:00
onenand.c
qdev: set properties with device_class_set_props()
2020-01-24 20:59:15 +01:00
pflash_cfi01.c
qdev: set properties with device_class_set_props()
2020-01-24 20:59:15 +01:00
pflash_cfi02.c
hw/block/pflash_cfi02: Remove unneeded variable assignment
2020-02-18 20:20:49 +01:00
swim.c
qdev: set properties with device_class_set_props()
2020-01-24 20:59:15 +01:00
tc58128.c
Include hw/hw.h exactly where needed
2019-08-16 13:31:52 +02:00
trace-events
nvme: Print 'cqid' for nvme_del_cq
2020-03-27 14:47:23 +01:00
vhost-user-blk.c
fix vhost_user_blk_watch crash
2020-03-29 09:52:13 -04:00
virtio-blk.c
virtio-blk: delete vqs on the error path in realize()
2020-03-29 09:52:13 -04:00
xen_blkif.h
xen: Import other xen/io/*.h
2019-06-24 10:42:30 +01:00
xen-block.c
xen-block: Fix uninitialized variable
2020-04-07 16:13:26 +01:00