71ad4713cc
The thread pool regulates itself: when idle, it kills threads until empty, when in demand, it creates new threads until full. This behaviour doesn't play well with latency sensitive workloads where the price of creating a new thread is too high. For example, when paired with qemu's '-mlock', or using safety features like SafeStack, creating a new thread has been measured take multiple milliseconds. In order to mitigate this let's introduce a new 'EventLoopBase' property to set the thread pool size. The threads will be created during the pool's initialization or upon updating the property's value, remain available during its lifetime regardless of demand, and destroyed upon freeing it. A properly characterized workload will then be able to configure the pool to avoid any latency spikes. Signed-off-by: Nicolas Saenz Julienne <nsaenzju@redhat.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Acked-by: Markus Armbruster <armbru@redhat.com> Message-id: 20220425075723.20019-4-nsaenzju@redhat.com Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
42 lines
1006 B
C
42 lines
1006 B
C
/*
|
|
* QEMU event-loop backend
|
|
*
|
|
* Copyright (C) 2022 Red Hat Inc
|
|
*
|
|
* Authors:
|
|
* Nicolas Saenz Julienne <nsaenzju@redhat.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
* See the COPYING file in the top-level directory.
|
|
*/
|
|
#ifndef QEMU_EVENT_LOOP_BASE_H
|
|
#define QEMU_EVENT_LOOP_BASE_H
|
|
|
|
#include "qom/object.h"
|
|
#include "block/aio.h"
|
|
#include "qemu/typedefs.h"
|
|
|
|
#define TYPE_EVENT_LOOP_BASE "event-loop-base"
|
|
OBJECT_DECLARE_TYPE(EventLoopBase, EventLoopBaseClass,
|
|
EVENT_LOOP_BASE)
|
|
|
|
struct EventLoopBaseClass {
|
|
ObjectClass parent_class;
|
|
|
|
void (*init)(EventLoopBase *base, Error **errp);
|
|
void (*update_params)(EventLoopBase *base, Error **errp);
|
|
bool (*can_be_deleted)(EventLoopBase *base);
|
|
};
|
|
|
|
struct EventLoopBase {
|
|
Object parent;
|
|
|
|
/* AioContext AIO engine parameters */
|
|
int64_t aio_max_batch;
|
|
|
|
/* AioContext thread pool parameters */
|
|
int64_t thread_pool_min;
|
|
int64_t thread_pool_max;
|
|
};
|
|
#endif
|