qemu-e2k/qga
Markus Armbruster 08e6464035 qga/vss-win32: Document the DLL requires non-null errp
requester.cpp uses this pattern to receive an error and pass it on to
the caller (err_is_set() macro peeled off for clarity):

    ... code that may set errset->errp ...
    if (errset->errp && *errset->errp) {
        ... handle error ...
    }

This breaks when errset->errp is null.  As far as I can tell, it
currently isn't, so this is merely fragile, not actually broken.

The robust way to do this is to receive the error in a local variable,
then propagate it up, like this:

    Error *err = NULL;

    ... code that may set err ...
    if (err)
        ... handle error ...
        error_propagate(errset->errp, err);
    }

See also commit 5e54769, 0f230bf, a903f40.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
2015-09-10 13:48:06 +02:00
..
installer qemu-ga: Fixed paths issue with MSI build 2015-09-01 11:07:09 -05:00
vss-win32 qga/vss-win32: Document the DLL requires non-null errp 2015-09-10 13:48:06 +02:00
channel-posix.c channel-posix: using qemu_set_nonblock() instead of fcntl(O_NONBLOCK) 2014-08-15 18:03:13 +01:00
channel-win32.c qemu-ga: debug printouts to help troubleshoot installation 2015-06-17 16:03:46 +02:00
channel.h
commands-posix.c qga: make split_list() return allocated strings 2015-09-01 11:07:10 -05:00
commands-win32.c qemu-ga: implement win32 guest-set-user-password 2015-09-01 13:16:26 -05:00
commands.c qga: Consistently name Error ** objects errp, and not err 2014-05-09 09:11:26 -04:00
guest-agent-command-state.c
guest-agent-core.h qga: Disable unsupported commands by default 2014-08-07 17:15:53 -05:00
main.c qga: add --dump-conf option 2015-09-01 13:16:25 -05:00
Makefile.objs
qapi-schema.json qga: misc spelling 2015-09-01 11:07:09 -05:00
service-win32.c
service-win32.h
vss-win32.c qga/vss-win32: Document the DLL requires non-null errp 2015-09-10 13:48:06 +02:00
vss-win32.h qga: Consistently name Error ** objects errp, and not err 2014-05-09 09:11:26 -04:00