e2cd0f4fb4
Semantics of end_optional() differ subtly from the other end_FOO()
callbacks: when start_FOO() succeeds, the matching end_FOO() gets
called regardless of what happens in between. end_optional() gets
called only when everything in between succeeds as well. Entirely
undocumented, like all of the visitor API.
The only user of Visitor Callback end_optional() never did anything,
and was removed in commit 9f9ab46.
I'm about to clean up error handling in the generated visitor code,
and end_optional() is in my way. No users mean no test cases, and
making non-trivial cleanup transformations without test cases doesn't
strike me as a good idea.
Drop end_optional(), and rename start_optional() to optional(). We
can always go back to a pair of callbacks when we have an actual need.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
63 lines
2.7 KiB
C
63 lines
2.7 KiB
C
/*
|
|
* Core Definitions for QAPI Visitor Classes
|
|
*
|
|
* Copyright IBM, Corp. 2011
|
|
*
|
|
* Authors:
|
|
* Anthony Liguori <aliguori@us.ibm.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU LGPL, version 2.1 or later.
|
|
* See the COPYING.LIB file in the top-level directory.
|
|
*
|
|
*/
|
|
#ifndef QAPI_VISITOR_CORE_H
|
|
#define QAPI_VISITOR_CORE_H
|
|
|
|
#include "qemu/typedefs.h"
|
|
#include "qapi/qmp/qobject.h"
|
|
#include "qapi/error.h"
|
|
#include <stdlib.h>
|
|
|
|
typedef struct GenericList
|
|
{
|
|
union {
|
|
void *value;
|
|
uint64_t padding;
|
|
};
|
|
struct GenericList *next;
|
|
} GenericList;
|
|
|
|
void visit_start_handle(Visitor *v, void **obj, const char *kind,
|
|
const char *name, Error **errp);
|
|
void visit_end_handle(Visitor *v, Error **errp);
|
|
void visit_start_struct(Visitor *v, void **obj, const char *kind,
|
|
const char *name, size_t size, Error **errp);
|
|
void visit_end_struct(Visitor *v, Error **errp);
|
|
void visit_start_implicit_struct(Visitor *v, void **obj, size_t size,
|
|
Error **errp);
|
|
void visit_end_implicit_struct(Visitor *v, Error **errp);
|
|
void visit_start_list(Visitor *v, const char *name, Error **errp);
|
|
GenericList *visit_next_list(Visitor *v, GenericList **list, Error **errp);
|
|
void visit_end_list(Visitor *v, Error **errp);
|
|
void visit_optional(Visitor *v, bool *present, const char *name,
|
|
Error **errp);
|
|
void visit_get_next_type(Visitor *v, int *obj, const int *qtypes,
|
|
const char *name, Error **errp);
|
|
void visit_type_enum(Visitor *v, int *obj, const char *strings[],
|
|
const char *kind, const char *name, Error **errp);
|
|
void visit_type_int(Visitor *v, int64_t *obj, const char *name, Error **errp);
|
|
void visit_type_uint8(Visitor *v, uint8_t *obj, const char *name, Error **errp);
|
|
void visit_type_uint16(Visitor *v, uint16_t *obj, const char *name, Error **errp);
|
|
void visit_type_uint32(Visitor *v, uint32_t *obj, const char *name, Error **errp);
|
|
void visit_type_uint64(Visitor *v, uint64_t *obj, const char *name, Error **errp);
|
|
void visit_type_int8(Visitor *v, int8_t *obj, const char *name, Error **errp);
|
|
void visit_type_int16(Visitor *v, int16_t *obj, const char *name, Error **errp);
|
|
void visit_type_int32(Visitor *v, int32_t *obj, const char *name, Error **errp);
|
|
void visit_type_int64(Visitor *v, int64_t *obj, const char *name, Error **errp);
|
|
void visit_type_size(Visitor *v, uint64_t *obj, const char *name, Error **errp);
|
|
void visit_type_bool(Visitor *v, bool *obj, const char *name, Error **errp);
|
|
void visit_type_str(Visitor *v, char **obj, const char *name, Error **errp);
|
|
void visit_type_number(Visitor *v, double *obj, const char *name, Error **errp);
|
|
|
|
#endif
|