Peter Maydell 0c285e0128 hw/block/fdc-sysbus: Always mark sysbus floppy controllers as not having DMA ... The sysbus floppy controllers (devices sysbus-fdc and sun-fdtwo) don't support DMA. The core floppy controller code expects this to be indicated by setting FDCtrl::dma_chann to -1. This used to be done in the device instance_init functions sysbus_fdc_initfn() and sun4m_fdc_initfn(), but in commit 1430759ec3 we refactored this code and accidentally lost the setting of dma_chann. For sysbus-fdc this has no ill effects because we were redundantly also setting dma_chann in fdctrl_init_sysbus(), but for sun-fdtwo this means that guests which try to enable DMA on the floppy controller will cause QEMU to crash because FDCtrl::dma is NULL. Set dma_chann to -1 in the common instance init, and remove the redundant code in fdctrl_init_sysbus() that is also setting it. There is a six-year-old FIXME comment in the jazz board code to the effect that in theory it should support doing DMA via a custom DMA controller. If anybody ever chooses to fix that they can do it by adding support for setting both FDCtrl::dma_chann and FDCtrl::dma. (A QOM link property 'dma-controller' on the sysbus device which can be set to an instance of IsaDmaClass is probably the way to go.) Fixes: 1430759ec3 ("hw/block/fdc: Extract SysBus floppy controllers to fdc-sysbus.c") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/958 Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> Message-Id: <20220505101842.2757905-1-peter.maydell@linaro.org> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>		2022-06-11 11:36:14 +02:00
..
dataplane	osdep: Move memalign-related functions to their own header	2022-03-07 13:16:49 +00:00
block.c	block: drop BLK_PERM_GRAPH_MOD	2022-01-14 12:03:16 +01:00
cdrom.c
ecc.c
fdc-internal.h
fdc-isa.c	acpi: fdc-isa: replace ISADeviceClass::build_aml with AcpiDevAmlIfClass:build_dev_aml	2022-06-09 19:32:48 -04:00
fdc-sysbus.c	hw/block/fdc-sysbus: Always mark sysbus floppy controllers as not having DMA	2022-06-11 11:36:14 +02:00
fdc.c	hw/block/fdc: Prevent end-of-track overrun (CVE-2021-3507)	2022-05-12 12:31:08 +02:00
hd-geometry.c
Kconfig	hw/block/fdc: Extract SysBus floppy controllers to fdc-sysbus.c	2021-06-25 08:53:28 -04:00
m25p80.c	hw: m25p80: allow write_enable latch get/set	2022-05-25 10:31:33 +02:00
meson.build	hw/block/fdc: Extract SysBus floppy controllers to fdc-sysbus.c	2021-06-25 08:53:28 -04:00
nand.c
onenand.c
pflash_cfi01.c	block: rename bdrv_invalidate_cache_all, blk_invalidate_cache and test_sync_op_invalidate_cache	2022-03-04 18:14:40 +01:00
pflash_cfi02.c
swim.c	qbus: Rename qbus_create_inplace() to qbus_init()	2021-09-30 13:42:10 +01:00
tc58128.c
trace-events	hw/block/fdc: Extract SysBus floppy controllers to fdc-sysbus.c	2021-06-25 08:53:28 -04:00
trace.h
vhost-user-blk.c	hw/vhost-user-scsi|blk: set supports_config flag correctly	2022-06-09 19:32:49 -04:00
virtio-blk.c	virtio: drop name parameter for virtio_init()	2022-05-16 04:38:40 -04:00
xen_blkif.h
xen-block.c