qemu-e2k/target-i386
Andreas Färber 7a05995361 target-i386: Defer MCE init
Commit de024815e3 (target-i386: QOM'ify
CPU init) moved mce_init() call from helper.c:cpu_x86_init() into
X86CPU's cpu.c:x86_cpu_initfn().
mce_init() checks for a family >= 6 though, so we could end up with a
sequence such as for -cpu somecpu,family=6:

  x86_cpu_initfn => X86CPU::family == 5
    mce_init => no-op
  cpu_x86_register => X86CPU::family = 6
  => MCE unexpectedly not init'ed

or for -cpu someothercpu,family=5:

  x86_cpu_initfn => X86CPU::family == 6
    mce_init => init'ed
  cpu_x86_register => X86CPU::family = 5
  => MCE unexpectedly init'ed

Therefore partially revert the above commit. To avoid moving
mce_init() back into helper.c, foresightedly move it into a
new x86_cpu_realize() function and, in lack of ObjectClass::realize,
call it directly from cpu_x86_init().

While at it, move the qemu_init_vcpu() call that used to follow
mce_init() in cpu_x86_init() into the new realizefn as well.

Reported-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
2012-05-12 14:17:52 +02:00
..
cpu-qom.h target-i386: Defer MCE init 2012-05-12 14:17:52 +02:00
cpu.c target-i386: Defer MCE init 2012-05-12 14:17:52 +02:00
cpu.h target-i386: Pass X86CPU to cpu_x86_register() 2012-04-25 10:51:35 +02:00
helper_template.h
helper.c target-i386: Defer MCE init 2012-05-12 14:17:52 +02:00
helper.h
hyperv.c
hyperv.h
kvm.c target-i386: Don't overuse CPUState 2012-03-14 22:20:25 +01:00
machine.c target-i386: Don't overuse CPUState 2012-03-14 22:20:25 +01:00
op_helper.c Use uintptr_t for various op related functions 2012-04-14 14:23:37 +00:00
ops_sse_header.h
ops_sse.h
svm.h
TODO
translate.c target-i386: Don't overuse CPUState 2012-03-14 22:20:25 +01:00