Markus Armbruster 0ca7b11709 qapi: Tighten QAPISchemaFOO.check() assertions ... When we introduced the QAPISchema intermediate representation (commit ac88219a6c), we took a shortcut: we left check_exprs() & friends alone instead of moving semantic checks into the QAPISchemaFOO.check(). check_exprs() still checks and reports errors, and the .check() assert check_exprs() did the job. There are a few gaps, though. QAPISchemaArrayType.check() neglects to assert the element type is not an array. Add the assertion. QAPISchemaObjectTypeVariants.check() neglects to assert the tag member is not optional. Add the assertion. It neglects to assert the tag member is not conditional. Add the assertion. It neglects to assert we actually have variants. Add the assertion. It asserts the variants are object types, but neglects to assert they don't have variants. Tighten the assertion. QAPISchemaObjectTypeVariants.check_clash() has the same issue. However, it can run only after .check(). Delete the assertion instead of tightening it. QAPISchemaAlternateType.check() neglects to assert the branch types don't conflict. Fixing that isn't trivial, so add just a TODO comment for now. It'll be resolved later in this series. Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Message-Id: <20190927134639.4284-2-armbru@redhat.com>		2019-09-28 17:17:18 +02:00
..
coccinelle
kvm	kvm: vmxcap: Enhance with latest features	2019-08-20 20:00:51 +02:00
modules	Include qemu-common.h exactly where needed	2019-06-12 13:20:20 +02:00
qapi	qapi: Tighten QAPISchemaFOO.check() assertions	2019-09-28 17:17:18 +02:00
qemu-guest-agent
qemugdb
qmp	qmp: make qmp-shell work with python3	2019-07-01 19:02:10 -03:00
tracetool	trace: Forbid event format ending with newline character	2019-09-18 10:20:15 +01:00
travis
analyse-9p-simpletrace.py
analyse-locks-simpletrace.py
analyze-inclusions
analyze-migration.py
archive-source.sh	archive-source: also create a stash for submodules	2019-07-23 15:53:25 +01:00
checkpatch.pl	docs: convert README, CODING_STYLE and HACKING to RST syntax	2019-09-05 14:27:06 +01:00
clean-header-guards.pl	scripts/clean-header-guards: Fix handling of trailing comments	2019-06-12 13:20:20 +02:00
clean-includes
cleanup-trace-events.pl
cocci-macro-file.h
coverity-model.c
create_config	create_config: remove $(CONFIG_SOFTMMU) hack	2019-07-15 20:58:37 +02:00
decodetree.py	decodetree: Suppress redundant declaration warnings	2019-08-19 08:13:14 -07:00
device-crash-test	python/qemu: split QEMUMachine out from underneath __init__.py	2019-07-01 19:02:10 -03:00
disas-objdump.pl
dump-guest-memory.py
extract-vsssdk-headers
feature_to_c.sh
fix-multiline-comments.sh
get_maintainer.pl
git-submodule.sh
git.orderfile	scripts/git.orderfile: Match QAPI schema more precisely	2019-09-24 14:07:22 +02:00
hxtool
make-release
minikconf.py	minikconf: don't print CONFIG_FOO=n lines	2019-08-21 16:29:57 +02:00
qapi-gen.py
qemu-binfmt-conf.sh
qemu-gdb.py
qemu-trace-stap
qemu-trace-stap.texi
refresh-pxe-roms.sh
render_block_graph.py	python/qemu: split QEMUMachine out from underneath __init__.py	2019-07-01 19:02:10 -03:00
replay-dump.py
shaderinclude.pl
show-fixed-bugs.sh
signrom.py
simpletrace.py
switch-timer-api
tap-driver.pl
tap-merge.pl
texi2pod.pl
tracetool.py
update-linux-headers.sh	update-linux-headers: handle new header file	2019-05-21 16:56:30 +02:00
vmstate-static-checker.py