1266c9b9f5
So far we relied on job->ret and strerror() to produce an error message for failed jobs. Not surprisingly, this tends to result in completely useless messages. This adds a Job.error field that can contain an error string for a failing job, and a parameter to job_completed() that sets the field. As a default, if NULL is passed, we continue to use strerror(job->ret). All existing callers are changed to pass NULL. They can be improved in separate patches. Signed-off-by: Kevin Wolf <kwolf@redhat.com> Reviewed-by: Max Reitz <mreitz@redhat.com> Reviewed-by: Jeff Cody <jcody@redhat.com>
184 lines
4.5 KiB
C
184 lines
4.5 KiB
C
/*
|
|
* QMP interface for background jobs
|
|
*
|
|
* Copyright (c) 2011 IBM Corp.
|
|
* Copyright (c) 2012, 2018 Red Hat, Inc.
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
* in the Software without restriction, including without limitation the rights
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
* THE SOFTWARE.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "qemu-common.h"
|
|
#include "qemu/job.h"
|
|
#include "qapi/qapi-commands-job.h"
|
|
#include "qapi/error.h"
|
|
#include "trace-root.h"
|
|
|
|
/* Get a job using its ID and acquire its AioContext */
|
|
static Job *find_job(const char *id, AioContext **aio_context, Error **errp)
|
|
{
|
|
Job *job;
|
|
|
|
*aio_context = NULL;
|
|
|
|
job = job_get(id);
|
|
if (!job) {
|
|
error_setg(errp, "Job not found");
|
|
return NULL;
|
|
}
|
|
|
|
*aio_context = job->aio_context;
|
|
aio_context_acquire(*aio_context);
|
|
|
|
return job;
|
|
}
|
|
|
|
void qmp_job_cancel(const char *id, Error **errp)
|
|
{
|
|
AioContext *aio_context;
|
|
Job *job = find_job(id, &aio_context, errp);
|
|
|
|
if (!job) {
|
|
return;
|
|
}
|
|
|
|
trace_qmp_job_cancel(job);
|
|
job_user_cancel(job, true, errp);
|
|
aio_context_release(aio_context);
|
|
}
|
|
|
|
void qmp_job_pause(const char *id, Error **errp)
|
|
{
|
|
AioContext *aio_context;
|
|
Job *job = find_job(id, &aio_context, errp);
|
|
|
|
if (!job) {
|
|
return;
|
|
}
|
|
|
|
trace_qmp_job_pause(job);
|
|
job_user_pause(job, errp);
|
|
aio_context_release(aio_context);
|
|
}
|
|
|
|
void qmp_job_resume(const char *id, Error **errp)
|
|
{
|
|
AioContext *aio_context;
|
|
Job *job = find_job(id, &aio_context, errp);
|
|
|
|
if (!job) {
|
|
return;
|
|
}
|
|
|
|
trace_qmp_job_resume(job);
|
|
job_user_resume(job, errp);
|
|
aio_context_release(aio_context);
|
|
}
|
|
|
|
void qmp_job_complete(const char *id, Error **errp)
|
|
{
|
|
AioContext *aio_context;
|
|
Job *job = find_job(id, &aio_context, errp);
|
|
|
|
if (!job) {
|
|
return;
|
|
}
|
|
|
|
trace_qmp_job_complete(job);
|
|
job_complete(job, errp);
|
|
aio_context_release(aio_context);
|
|
}
|
|
|
|
void qmp_job_finalize(const char *id, Error **errp)
|
|
{
|
|
AioContext *aio_context;
|
|
Job *job = find_job(id, &aio_context, errp);
|
|
|
|
if (!job) {
|
|
return;
|
|
}
|
|
|
|
trace_qmp_job_finalize(job);
|
|
job_finalize(job, errp);
|
|
aio_context_release(aio_context);
|
|
}
|
|
|
|
void qmp_job_dismiss(const char *id, Error **errp)
|
|
{
|
|
AioContext *aio_context;
|
|
Job *job = find_job(id, &aio_context, errp);
|
|
|
|
if (!job) {
|
|
return;
|
|
}
|
|
|
|
trace_qmp_job_dismiss(job);
|
|
job_dismiss(&job, errp);
|
|
aio_context_release(aio_context);
|
|
}
|
|
|
|
static JobInfo *job_query_single(Job *job, Error **errp)
|
|
{
|
|
JobInfo *info;
|
|
|
|
assert(!job_is_internal(job));
|
|
|
|
info = g_new(JobInfo, 1);
|
|
*info = (JobInfo) {
|
|
.id = g_strdup(job->id),
|
|
.type = job_type(job),
|
|
.status = job->status,
|
|
.current_progress = job->progress_current,
|
|
.total_progress = job->progress_total,
|
|
.has_error = !!job->error,
|
|
.error = g_strdup(job->error),
|
|
};
|
|
|
|
return info;
|
|
}
|
|
|
|
JobInfoList *qmp_query_jobs(Error **errp)
|
|
{
|
|
JobInfoList *head = NULL, **p_next = &head;
|
|
Job *job;
|
|
|
|
for (job = job_next(NULL); job; job = job_next(job)) {
|
|
JobInfoList *elem;
|
|
AioContext *aio_context;
|
|
|
|
if (job_is_internal(job)) {
|
|
continue;
|
|
}
|
|
elem = g_new0(JobInfoList, 1);
|
|
aio_context = job->aio_context;
|
|
aio_context_acquire(aio_context);
|
|
elem->value = job_query_single(job, errp);
|
|
aio_context_release(aio_context);
|
|
if (!elem->value) {
|
|
g_free(elem);
|
|
qapi_free_JobInfoList(head);
|
|
return NULL;
|
|
}
|
|
*p_next = elem;
|
|
p_next = &elem->next;
|
|
}
|
|
|
|
return head;
|
|
}
|