OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity
qemu-e2k/block
History
Ari Sundholm 13a028336f block/file-posix: Fix return value translation for AIO discards 
AIO discards regressed as a result of the following commit:
	0dfc7af2 block/file-posix: Optimize for macOS

When trying to run blkdiscard within a Linux guest, the request would
fail, with some errors in dmesg:

---- [ snip ] ----
[    4.010070] sd 2:0:0:0: [sda] tag#0 FAILED Result: hostbyte=DID_OK
driverbyte=DRIVER_SENSE
[    4.011061] sd 2:0:0:0: [sda] tag#0 Sense Key : Aborted Command
[current]
[    4.011061] sd 2:0:0:0: [sda] tag#0 Add. Sense: I/O process
terminated
[    4.011061] sd 2:0:0:0: [sda] tag#0 CDB: Unmap/Read sub-channel 42
00 00 00 00 00 00 00 18 00
[    4.011061] blk_update_request: I/O error, dev sda, sector 0
---- [ snip ] ----

This turns out to be a result of a flaw in changes to the error value
translation logic in handle_aiocb_discard(). The default return value
may be left untranslated in some configurations, and the wrong variable
is used in one translation.

Fix both issues.

Fixes: 0dfc7af2b28 ("block/file-posix: Optimize for macOS")
Cc: qemu-stable@nongnu.org
Signed-off-by: Ari Sundholm <ari@tuxera.com>
Signed-off-by: Emil Karlson <jkarlson@tuxera.com>
Reviewed-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20211019110954.4170931-1-ari@tuxera.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2021-11-02 13:02:46 +01:00
..
export
block/export/fuse.c: fix fuse-lseek on uclibc or musl
2021-09-01 14:38:08 +02:00
monitor
block/monitor: Consolidate hmp_handle_error calls to reduce redundant code
2021-09-01 12:57:31 +02:00
accounting.c
block/accounting: Use lock guard macros
2020-12-11 17:52:39 +01:00
aio_task.c
block/aio_task: assert max_busy_tasks is greater than 0
2021-10-05 18:56:41 +02:00
amend.c
…
backup.c
jobs: Give Job.force_cancel more meaning
2021-10-07 10:42:34 +02:00
blkdebug.c
block: use int64_t instead of int in driver discard handlers
2021-09-29 13:46:32 -05:00
blklogwrites.c
block: use int64_t instead of int in driver discard handlers
2021-09-29 13:46:32 -05:00
blkreplay.c
block: use int64_t instead of int in driver discard handlers
2021-09-29 13:46:32 -05:00
blkverify.c
block: use int64_t instead of uint64_t in driver write handlers
2021-09-29 13:46:31 -05:00
block-backend.c
block-backend: drop INT_MAX restriction from blk_check_byte_request()
2021-10-15 16:00:07 -05:00
block-copy.c
block/block-copy: block_copy_state_new(): drop extra arguments
2021-09-01 14:38:08 +02:00
block-gen.h
scripts: add block-coroutine-wrapper.py
2020-10-05 10:59:06 +01:00
bochs.c
block: use int64_t instead of uint64_t in driver read handlers
2021-09-29 13:46:31 -05:00
cloop.c
block: use int64_t instead of uint64_t in driver read handlers
2021-09-29 13:46:31 -05:00
commit.c
block: use int64_t instead of uint64_t in driver read handlers
2021-09-29 13:46:31 -05:00
copy-before-write.c
block: use int64_t instead of int in driver discard handlers
2021-09-29 13:46:32 -05:00
copy-before-write.h
block/copy-before-write: bdrv_cbw_append(): drop unused compress arg
2021-09-01 14:03:47 +02:00
copy-on-read.c
block: use int64_t instead of int in driver discard handlers
2021-09-29 13:46:32 -05:00
copy-on-read.h
copy-on-read: add filter drop function
2021-01-26 11:26:54 +01:00
coroutines.h
block-backend: drop blk_prw, use block-coroutine-wrapper
2021-10-15 15:53:24 -05:00
create.c
…
crypto.c
block: use int64_t instead of uint64_t in driver write handlers
2021-09-29 13:46:31 -05:00
crypto.h
nomaintainer: Fix Lesser GPL version number
2020-11-15 17:04:40 +01:00
curl.c
block: use int64_t instead of uint64_t in driver read handlers
2021-09-29 13:46:31 -05:00
dirty-bitmap.c
iotests: Improve and rename test 291 to qemu-img-bitmap
2021-07-21 14:14:41 -05:00
dmg-bz2.c
…
dmg-lzfse.c
block: Remove unused include
2020-11-09 15:44:21 +01:00
dmg.c
block: use int64_t instead of uint64_t in driver read handlers
2021-09-29 13:46:31 -05:00
dmg.h
…
file-posix.c
block/file-posix: Fix return value translation for AIO discards
2021-11-02 13:02:46 +01:00
file-win32.c
block: use int64_t instead of uint64_t in driver write handlers
2021-09-29 13:46:31 -05:00
filter-compress.c
block: use int64_t instead of int in driver discard handlers
2021-09-29 13:46:32 -05:00
gluster.c
block: use int64_t instead of int in driver discard handlers
2021-09-29 13:46:32 -05:00
io_uring.c
block/io_uring: resubmit when result is -EAGAIN
2021-07-29 17:14:55 +01:00
io.c
block: introduce max_hw_iov for use in scsi-generic
2021-10-06 10:25:55 +02:00
iscsi-opts.c
modules: add block module annotations
2021-07-09 18:20:27 +02:00
iscsi.c
block: use int64_t instead of int in driver discard handlers
2021-09-29 13:46:32 -05:00
linux-aio.c
linux-aio: limit the batch size using aio-max-batch parameter
2021-07-21 13:47:50 +01:00
meson.build
configure, meson: move libaio check to meson.build
2021-10-14 09:50:57 +02:00
mirror.c
mirror: Do not clear .cancelled
2021-10-07 10:42:50 +02:00
nbd.c
block/nbd: check that received handle is valid
2021-09-29 13:46:33 -05:00
nfs.c
block: use int64_t instead of uint64_t in driver write handlers
2021-09-29 13:46:31 -05:00
null.c
block: use int64_t instead of uint64_t in driver write handlers
2021-09-29 13:46:31 -05:00
nvme.c
block: use int64_t instead of int in driver discard handlers
2021-09-29 13:46:32 -05:00
parallels-ext.c
parallels: support bitmap extension for read-only mode
2021-03-08 14:56:55 +01:00
parallels.c
parallels: support bitmap extension for read-only mode
2021-03-08 14:56:55 +01:00
parallels.h
parallels: support bitmap extension for read-only mode
2021-03-08 14:56:55 +01:00
preallocate.c
block: use int64_t instead of int in driver discard handlers
2021-09-29 13:46:32 -05:00
progress_meter.c
progressmeter: protect with a mutex
2021-06-25 14:24:24 +03:00
qapi-sysemu.c
…
qapi.c
block: use GDateTime for formatting timestamp when dumping snapshot info
2021-06-14 13:28:50 +01:00
qcow2-bitmap.c
nbd patches for 2021-03-09
2021-03-11 13:57:08 +00:00
qcow2-cache.c
…
qcow2-cluster.c
qcow2: Silence clang -m32 compiler warning
2021-10-15 15:39:38 -05:00
qcow2-refcount.c
qcow2-refcount: check_refblocks(): add separate message for reserved
2021-09-15 18:42:38 +02:00
qcow2-snapshot.c
block: consistently use bdrv_is_read_only()
2021-06-02 14:23:20 +02:00
qcow2-threads.c
…
qcow2.c
block: use int64_t instead of int in driver discard handlers
2021-09-29 13:46:32 -05:00
qcow2.h
qcow2-refcount: check_refblocks(): add separate message for reserved
2021-09-15 18:42:38 +02:00
qcow.c
block: use int64_t instead of uint64_t in driver write handlers
2021-09-29 13:46:31 -05:00
qed-check.c
…
qed-cluster.c
…
qed-l2-cache.c
…
qed-table.c
…
qed.c
block: use int64_t instead of int in driver write_zeroes handlers
2021-09-29 13:46:32 -05:00
qed.h
…
quorum.c
block: use int64_t instead of int in driver write_zeroes handlers
2021-09-29 13:46:32 -05:00
raw-format.c
block: use int64_t instead of int in driver discard handlers
2021-09-29 13:46:32 -05:00
rbd.c
block: use int64_t instead of int in driver discard handlers
2021-09-29 13:46:32 -05:00
replication.c
job: @force parameter for job_cancel_sync()
2021-10-07 10:42:09 +02:00
snapshot.c
block/snapshot: Clarify goto fallback behavior
2021-06-24 09:49:04 +02:00
ssh.c
util/uri: do not check argument of uri_free()
2021-07-09 12:26:05 +02:00
stream.c
stream: Don't crash when node permission is denied
2021-03-19 10:15:06 +01:00
throttle-groups.c
block/throttle-groups: throttle_group_co_io_limits_intercept(): 64bit bytes
2021-02-03 08:14:00 -06:00
throttle.c
block: use int64_t instead of int in driver discard handlers
2021-09-29 13:46:32 -05:00
trace-events
block-backend: convert blk_co_pwritev_part to int64_t bytes
2021-10-15 15:47:18 -05:00
trace.h
…
vdi.c
block: use int64_t instead of uint64_t in driver write handlers
2021-09-29 13:46:31 -05:00
vhdx-endian.c
…
vhdx-log.c
block: consistently use bdrv_is_read_only()
2021-06-02 14:23:20 +02:00
vhdx.c
block/vhdx: Support vhdx image only with 512 bytes logical sector size
2020-09-15 11:05:13 +02:00
vhdx.h
…
vmdk.c
block: use int64_t instead of int in driver write_zeroes handlers
2021-09-29 13:46:32 -05:00
vpc.c
block: use int64_t instead of uint64_t in driver write handlers
2021-09-29 13:46:31 -05:00
vvfat.c
block: use int64_t instead of uint64_t in driver write handlers
2021-09-29 13:46:31 -05:00
win32-aio.c
…
write-threshold.c
write-threshold: deal with includes
2021-05-14 16:14:10 +02:00