72d41eb4b8
Neither stat(2) nor lseek(2) report the size of Linux devdax pmem
character device nodes. Commit 314aec4a6e
("hostmem-file: reject invalid pmem file sizes") added code to
hostmem-file.c to fetch the size from sysfs and compare against the
user-provided size=NUM parameter:
if (backend->size > size) {
error_setg(errp, "size property %" PRIu64 " is larger than "
"pmem file \"%s\" size %" PRIu64, backend->size,
fb->mem_path, size);
return;
}
It turns out that exec.c:qemu_ram_alloc_from_fd() already has an
equivalent size check but it skips devdax pmem character devices because
lseek(2) returns 0:
if (file_size > 0 && file_size < size) {
error_setg(errp, "backing store %s size 0x%" PRIx64
" does not match 'size' option 0x" RAM_ADDR_FMT,
mem_path, file_size, size);
return NULL;
}
This patch moves the devdax pmem file size code into get_file_size() so
that we check the memory size in a single place:
qemu_ram_alloc_from_fd(). This simplifies the code and makes it more
general.
This also fixes the problem that hostmem-file only checks the devdax
pmem file size when the pmem=on parameter is given. An unchecked
size=NUM parameter can lead to SIGBUS in QEMU so we must always fetch
the file size for Linux devdax pmem character device nodes.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20190830093056.12572-1-stefanha@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
230 lines
6.3 KiB
C
230 lines
6.3 KiB
C
/*
|
|
* QEMU Host Memory Backend for hugetlbfs
|
|
*
|
|
* Copyright (C) 2013-2014 Red Hat Inc
|
|
*
|
|
* Authors:
|
|
* Paolo Bonzini <pbonzini@redhat.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
* See the COPYING file in the top-level directory.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "qapi/error.h"
|
|
#include "qemu/error-report.h"
|
|
#include "qemu/module.h"
|
|
#include "sysemu/hostmem.h"
|
|
#include "sysemu/sysemu.h"
|
|
#include "qom/object_interfaces.h"
|
|
|
|
/* hostmem-file.c */
|
|
/**
|
|
* @TYPE_MEMORY_BACKEND_FILE:
|
|
* name of backend that uses mmap on a file descriptor
|
|
*/
|
|
#define TYPE_MEMORY_BACKEND_FILE "memory-backend-file"
|
|
|
|
#define MEMORY_BACKEND_FILE(obj) \
|
|
OBJECT_CHECK(HostMemoryBackendFile, (obj), TYPE_MEMORY_BACKEND_FILE)
|
|
|
|
typedef struct HostMemoryBackendFile HostMemoryBackendFile;
|
|
|
|
struct HostMemoryBackendFile {
|
|
HostMemoryBackend parent_obj;
|
|
|
|
char *mem_path;
|
|
uint64_t align;
|
|
bool discard_data;
|
|
bool is_pmem;
|
|
};
|
|
|
|
static void
|
|
file_backend_memory_alloc(HostMemoryBackend *backend, Error **errp)
|
|
{
|
|
#ifndef CONFIG_POSIX
|
|
error_setg(errp, "backend '%s' not supported on this host",
|
|
object_get_typename(OBJECT(backend)));
|
|
#else
|
|
HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(backend);
|
|
gchar *name;
|
|
|
|
if (!backend->size) {
|
|
error_setg(errp, "can't create backend with size 0");
|
|
return;
|
|
}
|
|
if (!fb->mem_path) {
|
|
error_setg(errp, "mem-path property not set");
|
|
return;
|
|
}
|
|
|
|
backend->force_prealloc = mem_prealloc;
|
|
name = host_memory_backend_get_name(backend);
|
|
memory_region_init_ram_from_file(&backend->mr, OBJECT(backend),
|
|
name,
|
|
backend->size, fb->align,
|
|
(backend->share ? RAM_SHARED : 0) |
|
|
(fb->is_pmem ? RAM_PMEM : 0),
|
|
fb->mem_path, errp);
|
|
g_free(name);
|
|
#endif
|
|
}
|
|
|
|
static char *get_mem_path(Object *o, Error **errp)
|
|
{
|
|
HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(o);
|
|
|
|
return g_strdup(fb->mem_path);
|
|
}
|
|
|
|
static void set_mem_path(Object *o, const char *str, Error **errp)
|
|
{
|
|
HostMemoryBackend *backend = MEMORY_BACKEND(o);
|
|
HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(o);
|
|
|
|
if (host_memory_backend_mr_inited(backend)) {
|
|
error_setg(errp, "cannot change property 'mem-path' of %s",
|
|
object_get_typename(o));
|
|
return;
|
|
}
|
|
g_free(fb->mem_path);
|
|
fb->mem_path = g_strdup(str);
|
|
}
|
|
|
|
static bool file_memory_backend_get_discard_data(Object *o, Error **errp)
|
|
{
|
|
return MEMORY_BACKEND_FILE(o)->discard_data;
|
|
}
|
|
|
|
static void file_memory_backend_set_discard_data(Object *o, bool value,
|
|
Error **errp)
|
|
{
|
|
MEMORY_BACKEND_FILE(o)->discard_data = value;
|
|
}
|
|
|
|
static void file_memory_backend_get_align(Object *o, Visitor *v,
|
|
const char *name, void *opaque,
|
|
Error **errp)
|
|
{
|
|
HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(o);
|
|
uint64_t val = fb->align;
|
|
|
|
visit_type_size(v, name, &val, errp);
|
|
}
|
|
|
|
static void file_memory_backend_set_align(Object *o, Visitor *v,
|
|
const char *name, void *opaque,
|
|
Error **errp)
|
|
{
|
|
HostMemoryBackend *backend = MEMORY_BACKEND(o);
|
|
HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(o);
|
|
Error *local_err = NULL;
|
|
uint64_t val;
|
|
|
|
if (host_memory_backend_mr_inited(backend)) {
|
|
error_setg(&local_err, "cannot change property '%s' of %s",
|
|
name, object_get_typename(o));
|
|
goto out;
|
|
}
|
|
|
|
visit_type_size(v, name, &val, &local_err);
|
|
if (local_err) {
|
|
goto out;
|
|
}
|
|
fb->align = val;
|
|
|
|
out:
|
|
error_propagate(errp, local_err);
|
|
}
|
|
|
|
static bool file_memory_backend_get_pmem(Object *o, Error **errp)
|
|
{
|
|
return MEMORY_BACKEND_FILE(o)->is_pmem;
|
|
}
|
|
|
|
static void file_memory_backend_set_pmem(Object *o, bool value, Error **errp)
|
|
{
|
|
HostMemoryBackend *backend = MEMORY_BACKEND(o);
|
|
HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(o);
|
|
|
|
if (host_memory_backend_mr_inited(backend)) {
|
|
|
|
error_setg(errp, "cannot change property 'pmem' of %s.",
|
|
object_get_typename(o));
|
|
return;
|
|
}
|
|
|
|
#ifndef CONFIG_LIBPMEM
|
|
if (value) {
|
|
Error *local_err = NULL;
|
|
|
|
error_setg(&local_err,
|
|
"Lack of libpmem support while setting the 'pmem=on'"
|
|
" of %s. We can't ensure data persistence.",
|
|
object_get_typename(o));
|
|
error_propagate(errp, local_err);
|
|
return;
|
|
}
|
|
#endif
|
|
|
|
fb->is_pmem = value;
|
|
}
|
|
|
|
static void file_backend_unparent(Object *obj)
|
|
{
|
|
HostMemoryBackend *backend = MEMORY_BACKEND(obj);
|
|
HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(obj);
|
|
|
|
if (host_memory_backend_mr_inited(backend) && fb->discard_data) {
|
|
void *ptr = memory_region_get_ram_ptr(&backend->mr);
|
|
uint64_t sz = memory_region_size(&backend->mr);
|
|
|
|
qemu_madvise(ptr, sz, QEMU_MADV_REMOVE);
|
|
}
|
|
}
|
|
|
|
static void
|
|
file_backend_class_init(ObjectClass *oc, void *data)
|
|
{
|
|
HostMemoryBackendClass *bc = MEMORY_BACKEND_CLASS(oc);
|
|
|
|
bc->alloc = file_backend_memory_alloc;
|
|
oc->unparent = file_backend_unparent;
|
|
|
|
object_class_property_add_bool(oc, "discard-data",
|
|
file_memory_backend_get_discard_data, file_memory_backend_set_discard_data,
|
|
&error_abort);
|
|
object_class_property_add_str(oc, "mem-path",
|
|
get_mem_path, set_mem_path,
|
|
&error_abort);
|
|
object_class_property_add(oc, "align", "int",
|
|
file_memory_backend_get_align,
|
|
file_memory_backend_set_align,
|
|
NULL, NULL, &error_abort);
|
|
object_class_property_add_bool(oc, "pmem",
|
|
file_memory_backend_get_pmem, file_memory_backend_set_pmem,
|
|
&error_abort);
|
|
}
|
|
|
|
static void file_backend_instance_finalize(Object *o)
|
|
{
|
|
HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(o);
|
|
|
|
g_free(fb->mem_path);
|
|
}
|
|
|
|
static const TypeInfo file_backend_info = {
|
|
.name = TYPE_MEMORY_BACKEND_FILE,
|
|
.parent = TYPE_MEMORY_BACKEND,
|
|
.class_init = file_backend_class_init,
|
|
.instance_finalize = file_backend_instance_finalize,
|
|
.instance_size = sizeof(HostMemoryBackendFile),
|
|
};
|
|
|
|
static void register_types(void)
|
|
{
|
|
type_register_static(&file_backend_info);
|
|
}
|
|
|
|
type_init(register_types);
|