19f7034773
The address_space_rw() function allows either reads or writes depending on the is_write argument passed to it; this is useful when the direction of the access is determined programmatically (as for instance when handling the KVM_EXIT_MMIO exit reason). Under the hood it just calls either address_space_write() or address_space_read_full(). We also use it a lot with a constant is_write argument, though, which has two issues: * when reading "address_space_rw(..., 1)" this is less immediately clear to the reader as being a write than "address_space_write(...)" * calling address_space_rw() bypasses the optimization in address_space_read() that fast-paths reads of a fixed length This commit was produced with the included Coccinelle script scripts/coccinelle/exec_rw_const.cocci. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> Reviewed-by: Laurent Vivier <lvivier@redhat.com> Reviewed-by: Cédric Le Goater <clg@kaod.org> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com> Reviewed-by: Cornelia Huck <cohuck@redhat.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Acked-by: David Gibson <david@gibson.dropbear.id.au> Message-Id: <20200218112457.22712-1-peter.maydell@linaro.org> [PMD: Update macvm_set_cr0() reported by Laurent Vivier] Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> |
||
|---|---|---|
| .. | ||
| cpu_restore_state.cocci | ||
| err-bad-newline.cocci | ||
| error_propagate_null.cocci | ||
| exec_rw_const.cocci | ||
| inplace-byteswaps.cocci | ||
| memory-region-init-ram.cocci | ||
| overflow_muldiv64.cocci | ||
| qobject.cocci | ||
| remove_local_err.cocci | ||
| remove_muldiv64.cocci | ||
| return_directly.cocci | ||
| round.cocci | ||
| simplify_muldiv64.cocci | ||
| swap_muldiv64.cocci | ||
| tcg_gen_extract.cocci | ||
| typecast.cocci | ||
| use-error_fatal.cocci | ||