qemu-e2k/tests/qemu-iotests
Eric Blake 1b5c15cebd nbd/client: Add hint when TLS is missing
I received an off-list report of failure to connect to an NBD server
expecting an x509 certificate, when the client was attempting something
similar to this command line:

$ ./x86_64-softmmu/qemu-system-x86_64 -name 'blah' -machine q35 -nodefaults \
  -object tls-creds-x509,id=tls0,endpoint=client,dir=$path_to_certs \
  -device virtio-scsi-pci,id=virtio_scsi_pci0,bus=pcie.0,addr=0x6 \
  -drive id=drive_image1,if=none,snapshot=off,aio=threads,cache=none,format=raw,file=nbd:localhost:9000,werror=stop,rerror=stop,tls-creds=tls0 \
  -device scsi-hd,id=image1,drive=drive_image1,bootindex=0
qemu-system-x86_64: -drive id=drive_image1,if=none,snapshot=off,aio=threads,cache=none,format=raw,file=nbd:localhost:9000,werror=stop,rerror=stop,tls-creds=tls0: TLS negotiation required before option 7 (go)
server reported: Option 0x7 not permitted before TLS

The problem?  As specified, -drive is trying to pass tls-creds to the
raw format driver instead of the nbd protocol driver, but before we
get to the point where we can detect that raw doesn't know what to do
with tls-creds, the nbd driver has already failed because the server
complained.  The fix to the broken command line?  Pass
'...,file.tls-creds=tls0' to ensure the tls-creds option is handed to
nbd, not raw.  But since the error message was rather cryptic, I'm
trying to improve the error message.

With this patch, the error message adds a line:

qemu-system-x86_64: -drive id=drive_image1,if=none,snapshot=off,aio=threads,cache=none,format=raw,file=nbd:localhost:9000,werror=stop,rerror=stop,tls-creds=tls0: TLS negotiation required before option 7 (go)
Did you forget a valid tls-creds?
server reported: Option 0x7 not permitted before TLS

And with luck, someone grepping for that error message will find this
commit message and figure out their command line mistake.  Sadly, the
only mention of file.tls-creds in our docs relates to an --image-opts
use of PSK encryption with qemu-img as the client, rather than x509
certificate encryption with qemu-kvm as the client.

CC: Tingting Mao <timao@redhat.com>
CC: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20190907172055.26870-1-eblake@redhat.com>
[eblake: squash in iotest 233 fix]
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
2019-09-24 07:30:19 -05:00
..
2018-01-23 12:34:43 +01:00
026
2019-09-03 14:56:06 +02:00
028
2019-09-13 12:18:37 +02:00
2017-07-11 17:45:02 +02:00
2019-07-30 12:25:43 +02:00
052
2019-09-03 14:56:06 +02:00
2017-05-11 12:08:24 +02:00
2017-09-06 15:19:01 +01:00
2019-07-12 15:42:23 +02:00
2019-06-14 14:16:57 +02:00
091
2019-09-03 14:56:06 +02:00
093
2019-08-16 16:28:02 -04:00
2018-06-11 16:18:45 +02:00
2019-08-16 10:25:16 +02:00
2017-10-26 15:01:14 +02:00
2016-05-19 16:45:31 +02:00
138
2019-05-07 17:14:21 +02:00
2019-05-07 17:14:21 +02:00
141
2019-08-19 17:13:26 +02:00
2019-08-19 17:13:26 +02:00
147
2019-09-10 08:58:43 +02:00
2016-09-20 22:10:57 +02:00
2016-09-20 22:10:57 +02:00
2017-09-26 15:00:32 +02:00
2016-09-20 22:10:57 +02:00
2017-09-18 19:43:38 -04:00
2017-02-12 00:47:42 +01:00
183
2019-09-13 12:18:37 +02:00
192
2019-09-13 12:18:37 +02:00
194
2018-04-10 16:33:43 +02:00
205
2019-09-10 08:58:43 +02:00
207
2019-06-24 16:01:04 +02:00
2019-06-24 16:01:04 +02:00
209
2018-03-13 15:44:09 -05:00
210
2019-02-25 15:11:27 +01:00
211
2019-02-25 15:11:28 +01:00
212
2019-02-25 15:11:27 +01:00
213
2019-02-25 15:11:27 +01:00
2018-05-15 16:15:21 +02:00
219
2019-06-14 14:16:57 +02:00
222
2018-07-10 11:55:11 +02:00
223
2019-03-09 20:55:44 +00:00
228
2019-02-25 15:11:27 +01:00
2019-02-25 15:11:27 +01:00
232
2019-09-10 08:58:43 +02:00
2019-03-19 15:49:29 +01:00
233
2019-06-13 08:50:47 -05:00
2019-02-01 13:46:44 +01:00
237
2019-02-25 15:11:27 +01:00
238
2019-08-16 16:28:02 -04:00
2019-02-01 13:46:44 +01:00
2019-03-19 15:49:29 +01:00
250
2019-06-04 16:55:58 +02:00
2019-06-04 16:55:58 +02:00
254
2019-08-16 16:28:03 -04:00
2019-08-16 16:28:03 -04:00
255
2019-07-19 13:19:17 +02:00
263
2019-09-16 15:37:12 +02:00
2019-09-16 15:37:12 +02:00
266
2019-09-10 08:58:43 +02:00
2019-09-10 08:58:43 +02:00
2019-06-13 08:50:47 -05:00
2019-09-16 15:37:12 +02:00

=== This is the QEMU I/O test suite ===

* Intro

This package contains a simple test suite for the I/O layer of qemu.
It does not require a guest, but only the qemu, qemu-img and qemu-io
binaries.  This does limit it to exercise the low-level I/O path only
but no actual block drivers like ide, scsi or virtio.

* Usage

Just run ./check to run all tests for the raw image format, or ./check
-qcow2 to test the qcow2 image format.  The output of ./check -h explains
additional options to test further image formats or I/O methods.

* Feedback and patches

Please send improvements to the test suite, general feedback or just
reports of failing tests cases to qemu-devel@nongnu.org with a CC:
to qemu-block@nongnu.org.