qemu-e2k/tests/qtest/boot-order-test.c
Daniel P. Berrangé 855436dbf7 tests/qtest: replace qmp_discard_response with qtest_qmp_assert_success
The qmp_discard_response method simply ignores the result of the QMP
command, merely unref'ing the object. This is a bad idea for tests
as it leaves no trace if the QMP command unexpectedly failed. The
qtest_qmp_assert_success method will validate that the QMP command
returned without error, and if errors occur, it will print a message
on the console aiding debugging.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20230421171411.566300-2-berrange@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Zhang Chen <chen.zhang@intel.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
2023-05-16 09:14:18 +02:00

183 lines
4.9 KiB
C

/*
* Boot order test cases.
*
* Copyright (c) 2013 Red Hat Inc.
*
* Authors:
* Markus Armbruster <armbru@redhat.com>,
*
* This work is licensed under the terms of the GNU GPL, version 2 or later.
* See the COPYING file in the top-level directory.
*/
#include "qemu/osdep.h"
#include "libqos/fw_cfg.h"
#include "libqtest.h"
#include "qapi/qmp/qdict.h"
#include "standard-headers/linux/qemu_fw_cfg.h"
typedef struct {
const char *args;
uint64_t expected_boot;
uint64_t expected_reboot;
} boot_order_test;
static void test_a_boot_order(const char *machine,
const char *test_args,
uint64_t (*read_boot_order)(QTestState *),
uint64_t expected_boot,
uint64_t expected_reboot)
{
uint64_t actual;
QTestState *qts;
if (machine && !qtest_has_machine(machine)) {
g_test_skip("Machine is not available");
return;
}
qts = qtest_initf("-nodefaults%s%s %s", machine ? " -M " : "",
machine ?: "", test_args);
actual = read_boot_order(qts);
g_assert_cmphex(actual, ==, expected_boot);
qtest_qmp_assert_success(qts, "{ 'execute': 'system_reset' }");
/*
* system_reset only requests reset. We get a RESET event after
* the actual reset completes. Need to wait for that.
*/
qtest_qmp_eventwait(qts, "RESET");
actual = read_boot_order(qts);
g_assert_cmphex(actual, ==, expected_reboot);
qtest_quit(qts);
}
static void test_boot_orders(const char *machine,
uint64_t (*read_boot_order)(QTestState *),
const boot_order_test *tests)
{
int i;
for (i = 0; tests[i].args; i++) {
test_a_boot_order(machine, tests[i].args,
read_boot_order,
tests[i].expected_boot,
tests[i].expected_reboot);
}
}
static uint8_t read_mc146818(QTestState *qts, uint16_t port, uint8_t reg)
{
qtest_outb(qts, port, reg);
return qtest_inb(qts, port + 1);
}
static uint64_t read_boot_order_pc(QTestState *qts)
{
uint8_t b1 = read_mc146818(qts, 0x70, 0x38);
uint8_t b2 = read_mc146818(qts, 0x70, 0x3d);
return b1 | (b2 << 8);
}
static const boot_order_test test_cases_pc[] = {
{ "",
0x1230, 0x1230 },
{ "-no-fd-bootchk",
0x1231, 0x1231 },
{ "-boot c",
0x0200, 0x0200 },
{ "-boot nda",
0x3410, 0x3410 },
{ "-boot order=",
0, 0 },
{ "-boot order= -boot order=c",
0x0200, 0x0200 },
{ "-boot once=a",
0x0100, 0x1230 },
{ "-boot once=a -no-fd-bootchk",
0x0101, 0x1231 },
{ "-boot once=a,order=c",
0x0100, 0x0200 },
{ "-boot once=d -boot order=nda",
0x0300, 0x3410 },
{ "-boot once=a -boot once=b -boot once=c",
0x0200, 0x1230 },
{}
};
static void test_pc_boot_order(void)
{
test_boot_orders(NULL, read_boot_order_pc, test_cases_pc);
}
static uint64_t read_boot_order_pmac(QTestState *qts)
{
g_autoptr(QFWCFG) fw_cfg = mm_fw_cfg_init(qts, 0xf0000510);
return qfw_cfg_get_u16(fw_cfg, FW_CFG_BOOT_DEVICE);
}
static const boot_order_test test_cases_fw_cfg[] = {
{ "", 'c', 'c' },
{ "-boot c", 'c', 'c' },
{ "-boot d", 'd', 'd' },
{ "-boot once=d,order=c", 'd', 'c' },
{}
};
static void test_pmac_oldworld_boot_order(void)
{
test_boot_orders("g3beige", read_boot_order_pmac, test_cases_fw_cfg);
}
static void test_pmac_newworld_boot_order(void)
{
test_boot_orders("mac99", read_boot_order_pmac, test_cases_fw_cfg);
}
static uint64_t read_boot_order_sun4m(QTestState *qts)
{
g_autoptr(QFWCFG) fw_cfg = mm_fw_cfg_init(qts, 0xd00000510ULL);
return qfw_cfg_get_u16(fw_cfg, FW_CFG_BOOT_DEVICE);
}
static void test_sun4m_boot_order(void)
{
test_boot_orders("SS-5", read_boot_order_sun4m, test_cases_fw_cfg);
}
static uint64_t read_boot_order_sun4u(QTestState *qts)
{
g_autoptr(QFWCFG) fw_cfg = io_fw_cfg_init(qts, 0x510);
return qfw_cfg_get_u16(fw_cfg, FW_CFG_BOOT_DEVICE);
}
static void test_sun4u_boot_order(void)
{
test_boot_orders("sun4u", read_boot_order_sun4u, test_cases_fw_cfg);
}
int main(int argc, char *argv[])
{
const char *arch = qtest_get_arch();
g_test_init(&argc, &argv, NULL);
if (strcmp(arch, "i386") == 0 || strcmp(arch, "x86_64") == 0) {
qtest_add_func("boot-order/pc", test_pc_boot_order);
} else if (strcmp(arch, "ppc") == 0 || strcmp(arch, "ppc64") == 0) {
qtest_add_func("boot-order/pmac_oldworld",
test_pmac_oldworld_boot_order);
qtest_add_func("boot-order/pmac_newworld",
test_pmac_newworld_boot_order);
} else if (strcmp(arch, "sparc") == 0) {
qtest_add_func("boot-order/sun4m", test_sun4m_boot_order);
} else if (strcmp(arch, "sparc64") == 0) {
qtest_add_func("boot-order/sun4u", test_sun4u_boot_order);
}
return g_test_run();
}