7b99fb30b3
The pca9552 INPUT0 and INPUT1 registers are supposed to hold the logical values of the LED pins. A logical 0 should be seen in the INPUT0/1 registers for a pin when its corresponding LSn bits are set to 0, which is also the state needed for turning on an LED in a typical usage scenario. Existing code was doing the opposite and setting INPUT0/1 bit to a 1 when the LSn bit was set to 0, so this commit fixes that. Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au> Signed-off-by: Glenn Miles <milesg@linux.vnet.ibm.com> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
94 lines
2.3 KiB
C
94 lines
2.3 KiB
C
/*
|
|
* QTest testcase for the PCA9552 LED blinker
|
|
*
|
|
* Copyright (c) 2017-2018, IBM Corporation.
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
* See the COPYING file in the top-level directory.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
|
|
#include "libqtest.h"
|
|
#include "libqos/qgraph.h"
|
|
#include "libqos/i2c.h"
|
|
#include "hw/misc/pca9552_regs.h"
|
|
|
|
#define PCA9552_TEST_ID "pca9552-test"
|
|
#define PCA9552_TEST_ADDR 0x60
|
|
|
|
static void pca9552_init(QI2CDevice *i2cdev)
|
|
{
|
|
/* Switch on LEDs 0 and 12 */
|
|
i2c_set8(i2cdev, PCA9552_LS0, 0x54);
|
|
i2c_set8(i2cdev, PCA9552_LS3, 0x54);
|
|
}
|
|
|
|
static void receive_autoinc(void *obj, void *data, QGuestAllocator *alloc)
|
|
{
|
|
QI2CDevice *i2cdev = (QI2CDevice *)obj;
|
|
uint8_t resp;
|
|
uint8_t reg = PCA9552_LS0 | PCA9552_AUTOINC;
|
|
|
|
pca9552_init(i2cdev);
|
|
|
|
qi2c_send(i2cdev, ®, 1);
|
|
|
|
/* PCA9552_LS0 */
|
|
qi2c_recv(i2cdev, &resp, 1);
|
|
g_assert_cmphex(resp, ==, 0x54);
|
|
|
|
/* PCA9552_LS1 */
|
|
qi2c_recv(i2cdev, &resp, 1);
|
|
g_assert_cmphex(resp, ==, 0x55);
|
|
|
|
/* PCA9552_LS2 */
|
|
qi2c_recv(i2cdev, &resp, 1);
|
|
g_assert_cmphex(resp, ==, 0x55);
|
|
|
|
/* PCA9552_LS3 */
|
|
qi2c_recv(i2cdev, &resp, 1);
|
|
g_assert_cmphex(resp, ==, 0x54);
|
|
}
|
|
|
|
static void send_and_receive(void *obj, void *data, QGuestAllocator *alloc)
|
|
{
|
|
QI2CDevice *i2cdev = (QI2CDevice *)obj;
|
|
uint8_t value;
|
|
|
|
value = i2c_get8(i2cdev, PCA9552_LS0);
|
|
g_assert_cmphex(value, ==, 0x55);
|
|
|
|
value = i2c_get8(i2cdev, PCA9552_INPUT0);
|
|
g_assert_cmphex(value, ==, 0xFF);
|
|
|
|
pca9552_init(i2cdev);
|
|
|
|
value = i2c_get8(i2cdev, PCA9552_LS0);
|
|
g_assert_cmphex(value, ==, 0x54);
|
|
|
|
value = i2c_get8(i2cdev, PCA9552_INPUT0);
|
|
g_assert_cmphex(value, ==, 0xFE);
|
|
|
|
value = i2c_get8(i2cdev, PCA9552_LS3);
|
|
g_assert_cmphex(value, ==, 0x54);
|
|
|
|
value = i2c_get8(i2cdev, PCA9552_INPUT1);
|
|
g_assert_cmphex(value, ==, 0xEF);
|
|
}
|
|
|
|
static void pca9552_register_nodes(void)
|
|
{
|
|
QOSGraphEdgeOptions opts = {
|
|
.extra_device_opts = "address=0x60"
|
|
};
|
|
add_qi2c_address(&opts, &(QI2CAddress) { 0x60 });
|
|
|
|
qos_node_create_driver("pca9552", i2c_device_create);
|
|
qos_node_consumes("pca9552", "i2c-bus", &opts);
|
|
|
|
qos_add_test("tx-rx", "pca9552", send_and_receive, NULL);
|
|
qos_add_test("rx-autoinc", "pca9552", receive_autoinc, NULL);
|
|
}
|
|
libqos_init(pca9552_register_nodes);
|