QEMU With E2K User Support
Go to file
Michael Tokarev 1e35d32789 linux-user: fix getgroups/setgroups allocations
linux-user getgroups(), setgroups(), getgroups32() and setgroups32()
used alloca() to allocate grouplist arrays, with unchecked gidsetsize
coming from the "guest".  With NGROUPS_MAX being 65536 (linux, and it
is common for an application to allocate NGROUPS_MAX for getgroups()),
this means a typical allocation is half the megabyte on the stack.
Which just overflows stack, which leads to immediate SIGSEGV in actual
system getgroups() implementation.

An example of such issue is aptitude, eg
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=811087#72

Cap gidsetsize to NGROUPS_MAX (return EINVAL if it is larger than that),
and use heap allocation for grouplist instead of alloca().  While at it,
fix coding style and make all 4 implementations identical.

Try to not impose random limits - for example, allow gidsetsize to be
negative for getgroups() - just do not allocate negative-sized grouplist
in this case but still do actual getgroups() call.  But do not allow
negative gidsetsize for setgroups() since its argument is unsigned.

Capping by NGROUPS_MAX seems a bit arbitrary, - we can do more, it is
not an error if set size will be NGROUPS_MAX+1. But we should not allow
integer overflow for the array being allocated. Maybe it is enough to
just call g_try_new() and return ENOMEM if it fails.

Maybe there's also no need to convert setgroups() since this one is
usually smaller and known beforehand (KERN_NGROUPS_MAX is actually 63, -
this is apparently a kernel-imposed limit for runtime group set).

The patch fixes aptitude segfault mentioned above.

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Message-Id: <20230409105327.1273372-1-mjt@msgid.tls.msk.ru>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
2023-05-17 07:20:29 +02:00
.github/workflows
.gitlab/issue_templates .gitlab/issue_templates: Move suggestions into comments 2022-12-15 15:19:24 +01:00
.gitlab-ci.d .gitlab-ci.d/cirrus: Drop the CI job for compiling with FreeBSD 12 2023-04-27 14:58:23 +01:00
accel Fix race condition that can cause a crash at startup. 2023-04-04 19:50:22 +01:00
audio audio/dbus: there are no sender for p2p mode 2023-03-13 22:57:39 +04:00
authz error: Drop superfluous #include "qapi/qmp/qerror.h" 2023-02-23 13:56:14 +01:00
backends thread-pool: avoid passing the pool parameter every time 2023-04-25 13:17:28 +02:00
block Block layer patches 2023-04-26 07:22:37 +01:00
bsd-user include/exec: Change reserved_va semantics to last byte 2023-03-28 15:23:10 -07:00
chardev chardev: Allow setting file chardev input file on the command line 2023-04-20 06:50:11 +02:00
common-user common-user/host/ppc: Implement safe-syscall.inc.S 2023-01-23 14:39:48 -10:00
configs s390x/gdb: Split s390-virt.xml 2023-04-28 08:05:37 +02:00
contrib contrib/gitdm: add group map for AMD 2023-03-22 15:08:26 +00:00
crypto win32: replace closesocket() with close() wrapper 2023-03-13 15:39:31 +04:00
disas Fix incorrect register name in disassembler for fmv,fabs,fneg instructions 2023-03-14 16:36:43 +10:00
docs QAPI patches patches for 2023-04-28 2023-04-28 23:34:54 +01:00
dtc@b6910bec11
dump *: Add missing includes of qemu/error-report.h 2023-03-22 15:06:57 +00:00
ebpf ebpf: fix compatibility with libbpf 1.0+ 2023-03-10 17:26:47 +08:00
fpu
fsdev Don't include headers already included by qemu/osdep.h 2023-02-08 07:28:05 +01:00
gdb-xml s390x/gdb: Split s390-virt.xml 2023-04-28 08:05:37 +02:00
gdbstub gdbstub: don't report auxv feature unless on Linux 2023-04-04 15:56:44 +01:00
hw * Prevent reentrant DMA accesses by default 2023-04-28 10:55:57 +01:00
include * Fix compilation issues under Debian 10 2023-04-29 23:07:17 +01:00
io io: mark mixed functions that can suspend 2023-04-20 11:17:35 +02:00
libdecnumber
linux-headers Update linux headers to v6.3rc5 2023-04-28 15:55:55 +02:00
linux-user linux-user: fix getgroups/setgroups allocations 2023-05-17 07:20:29 +02:00
meson@3a9b285a55
migration migration: Make dirty_bytes_last_sync atomic 2023-04-27 16:39:54 +02:00
monitor monitor: convert monitor_cleanup() to AIO_WAIT_WHILE_UNLOCKED() 2023-04-25 13:17:28 +02:00
nbd nbd: mark more coroutine_fns, do not use co_wrappers 2023-04-25 13:17:28 +02:00
net vdpa: accept VIRTIO_NET_F_SPEED_DUPLEX in SVQ 2023-04-21 03:08:21 -04:00
pc-bios update edk2 to 202302 stable tag 2023-03-20 13:43:35 +00:00
plugins include/qemu/plugin: Inline qemu_plugin_disable_mem_helpers 2023-03-22 15:06:57 +00:00
po
python python: drop pipenv 2023-02-22 23:35:03 -05:00
qapi * Fix compilation issues under Debian 10 2023-04-29 23:07:17 +01:00
qga qga/qapi-schema: Fix member documentation markup 2023-04-28 11:48:34 +02:00
qobject
qom qom/object_interfaces: Fix QAPI headers included 2023-02-27 22:29:01 +01:00
replay replay: Simplify setting replay blockers 2023-02-23 14:10:17 +01:00
roms edk2: replace build scripts 2023-03-20 10:36:31 +01:00
scripts * Fix compilation issues under Debian 10 2023-04-29 23:07:17 +01:00
scsi qemu-pr-helper: mark more coroutine_fns 2023-04-25 13:17:28 +02:00
semihosting gdbstub: Adjust gdb_do_syscall to only use uint32_t and uint64_t 2023-03-07 20:44:09 +00:00
softmmu memory: prevent dma-reentracy issues 2023-04-28 11:20:01 +02:00
stats cryptodev: Support query-stats QMP command 2023-03-07 12:38:59 -05:00
storage-daemon qapi storage-daemon/qapi: Fix documentation section structure 2023-04-28 11:48:34 +02:00
stubs stubs: split semihosting_get_target from system only stubs 2023-03-07 20:44:09 +00:00
subprojects Fix libvhost-user.c compilation. 2023-04-28 12:50:34 +02:00
target * Fix compilation issues under Debian 10 2023-04-29 23:07:17 +01:00
tcg tcg/riscv: Conditionalize tcg_out_exts_i32_i64 2023-04-23 08:46:45 +01:00
tests tests: vhost-user-test: release mutex on protocol violation 2023-04-28 15:56:41 +02:00
tools ebpf: fix compatibility with libbpf 1.0+ 2023-03-10 17:26:47 +08:00
trace trace: Do not try to include QMP commands in user emulation binaries 2023-02-27 22:29:01 +01:00
ui spice: move client_migrate_info command to ui/ 2023-04-24 15:01:46 +02:00
util * Fix compilation issues under Debian 10 2023-04-29 23:07:17 +01:00
.dir-locals.el
.editorconfig
.exrc
.gdbinit
.git-blame-ignore-revs metadata: add .git-blame-ignore-revs 2023-04-04 15:56:44 +01:00
.gitattributes
.gitignore build-sys: add slirp.wrap 2023-04-20 11:17:34 +02:00
.gitlab-ci.yml
.gitmodules hw/misc/sga: Remove the deprecated "sga" device 2023-02-14 09:02:42 +01:00
.gitpublish
.mailmap Add my old and new work email mapping and use work email to support biosbits 2023-04-21 03:08:21 -04:00
.patchew.yml
.readthedocs.yml
.travis.yml travis.yml: Add missing 'flex', 'bison' packages to 'GCC (user)' job 2023-04-20 11:24:50 +02:00
block.c block: add missing coroutine_fn to bdrv_sum_allocated_file_size() 2023-04-25 13:17:28 +02:00
blockdev-nbd.c
blockdev.c block: Convert bdrv_is_inserted() to co_wrapper 2023-02-01 16:52:32 +01:00
blockjob.c include/block: Untangle inclusion loops 2023-01-20 07:24:28 +01:00
configure configure: Honour cross-prefix when finding ObjC compiler 2023-04-20 11:17:36 +02:00
COPYING
COPYING.LIB
cpu.c cpu: Remove parameter of list_cpus() 2023-04-20 11:25:32 +02:00
cpus-common.c cpus-common: stop using mb_set/mb_read 2023-04-29 14:19:01 +02:00
disas.c target/loongarch: Enable the disassembler for host tcg 2023-01-23 15:36:36 -10:00
event-loop-base.c
gitdm.config contrib/gitdm: add group map for AMD 2023-03-22 15:08:26 +00:00
hmp-commands-info.hx hmp: add cryptodev info command 2023-03-07 12:38:59 -05:00
hmp-commands.hx monitor: restrict command getfd to POSIX hosts 2023-03-13 15:46:09 +04:00
iothread.c iothread: Remove unused IOThreadClass / IOTHREAD_CLASS 2023-02-27 13:27:05 +00:00
job-qmp.c qapi job: Elide redundant has_FOO in generated C 2022-12-14 20:04:47 +01:00
job.c
Kconfig
Kconfig.host
LICENSE
MAINTAINERS MAINTAINERS: Cover tests/avocado/machine_aspeed.py 2023-04-27 14:58:23 +01:00
Makefile Makefile: qemu-bundle is a directory 2023-03-01 13:08:20 +01:00
memory_ldst.c.inc
meson_options.txt meson_options.txt: Enable qom-cast-debug by default again 2023-04-21 04:25:52 -04:00
meson.build util: import GTree as QTree 2023-03-28 15:23:10 -07:00
module-common.c
os-posix.c Refactoring: refactor TFR() macro to RETRY_ON_EINTR() 2023-01-09 13:50:47 +01:00
os-win32.c
page-vary-common.c
page-vary.c
qemu-bridge-helper.c
qemu-edid.c
qemu-img-cmds.hx
qemu-img.c block: Mark bdrv_co_copy_range() GRAPH_RDLOCK 2023-02-23 19:49:20 +01:00
qemu-io-cmds.c qemu-io: add -r option to register I/O buffer 2023-02-09 10:22:30 -05:00
qemu-io.c
qemu-keymap.c qemu-keymap: Silence memory leak warning from Clang's sanitizer 2023-02-27 09:15:39 +01:00
qemu-nbd.c
qemu-options.hx qemu-options.hx: Update the reduced-phys-bits documentation 2023-04-28 12:50:34 +02:00
qemu.nsi
qemu.sasl
README.rst
replication.c
trace-events accel/tcg: Remove trace events from trace-root.h 2022-12-20 17:11:12 -08:00
VERSION Open 8.1 development tree 2023-04-20 10:05:25 +01:00
version.rc

===========
QEMU README
===========

QEMU is a generic and open source machine & userspace emulator and
virtualizer.

QEMU is capable of emulating a complete machine in software without any
need for hardware virtualization support. By using dynamic translation,
it achieves very good performance. QEMU can also integrate with the Xen
and KVM hypervisors to provide emulated hardware while allowing the
hypervisor to manage the CPU. With hypervisor support, QEMU can achieve
near native performance for CPUs. When QEMU emulates CPUs directly it is
capable of running operating systems made for one machine (e.g. an ARMv7
board) on a different machine (e.g. an x86_64 PC board).

QEMU is also capable of providing userspace API virtualization for Linux
and BSD kernel interfaces. This allows binaries compiled against one
architecture ABI (e.g. the Linux PPC64 ABI) to be run on a host using a
different architecture ABI (e.g. the Linux x86_64 ABI). This does not
involve any hardware emulation, simply CPU and syscall emulation.

QEMU aims to fit into a variety of use cases. It can be invoked directly
by users wishing to have full control over its behaviour and settings.
It also aims to facilitate integration into higher level management
layers, by providing a stable command line interface and monitor API.
It is commonly invoked indirectly via the libvirt library when using
open source applications such as oVirt, OpenStack and virt-manager.

QEMU as a whole is released under the GNU General Public License,
version 2. For full licensing details, consult the LICENSE file.


Documentation
=============

Documentation can be found hosted online at
`<https://www.qemu.org/documentation/>`_. The documentation for the
current development version that is available at
`<https://www.qemu.org/docs/master/>`_ is generated from the ``docs/``
folder in the source tree, and is built by `Sphinx
<https://www.sphinx-doc.org/en/master/>`_.


Building
========

QEMU is multi-platform software intended to be buildable on all modern
Linux platforms, OS-X, Win32 (via the Mingw64 toolchain) and a variety
of other UNIX targets. The simple steps to build QEMU are:


.. code-block:: shell

  mkdir build
  cd build
  ../configure
  make

Additional information can also be found online via the QEMU website:

* `<https://wiki.qemu.org/Hosts/Linux>`_
* `<https://wiki.qemu.org/Hosts/Mac>`_
* `<https://wiki.qemu.org/Hosts/W32>`_


Submitting patches
==================

The QEMU source code is maintained under the GIT version control system.

.. code-block:: shell

   git clone https://gitlab.com/qemu-project/qemu.git

When submitting patches, one common approach is to use 'git
format-patch' and/or 'git send-email' to format & send the mail to the
qemu-devel@nongnu.org mailing list. All patches submitted must contain
a 'Signed-off-by' line from the author. Patches should follow the
guidelines set out in the `style section
<https://www.qemu.org/docs/master/devel/style.html>`_ of
the Developers Guide.

Additional information on submitting patches can be found online via
the QEMU website

* `<https://wiki.qemu.org/Contribute/SubmitAPatch>`_
* `<https://wiki.qemu.org/Contribute/TrivialPatches>`_

The QEMU website is also maintained under source control.

.. code-block:: shell

  git clone https://gitlab.com/qemu-project/qemu-web.git

* `<https://www.qemu.org/2017/02/04/the-new-qemu-website-is-up/>`_

A 'git-publish' utility was created to make above process less
cumbersome, and is highly recommended for making regular contributions,
or even just for sending consecutive patch series revisions. It also
requires a working 'git send-email' setup, and by default doesn't
automate everything, so you may want to go through the above steps
manually for once.

For installation instructions, please go to

*  `<https://github.com/stefanha/git-publish>`_

The workflow with 'git-publish' is:

.. code-block:: shell

  $ git checkout master -b my-feature
  $ # work on new commits, add your 'Signed-off-by' lines to each
  $ git publish

Your patch series will be sent and tagged as my-feature-v1 if you need to refer
back to it in the future.

Sending v2:

.. code-block:: shell

  $ git checkout my-feature # same topic branch
  $ # making changes to the commits (using 'git rebase', for example)
  $ git publish

Your patch series will be sent with 'v2' tag in the subject and the git tip
will be tagged as my-feature-v2.

Bug reporting
=============

The QEMU project uses GitLab issues to track bugs. Bugs
found when running code built from QEMU git or upstream released sources
should be reported via:

* `<https://gitlab.com/qemu-project/qemu/-/issues>`_

If using QEMU via an operating system vendor pre-built binary package, it
is preferable to report bugs to the vendor's own bug tracker first. If
the bug is also known to affect latest upstream code, it can also be
reported via GitLab.

For additional information on bug reporting consult:

* `<https://wiki.qemu.org/Contribute/ReportABug>`_


ChangeLog
=========

For version history and release notes, please visit
`<https://wiki.qemu.org/ChangeLog/>`_ or look at the git history for
more detailed information.


Contact
=======

The QEMU community can be contacted in a number of ways, with the two
main methods being email and IRC

* `<mailto:qemu-devel@nongnu.org>`_
* `<https://lists.nongnu.org/mailman/listinfo/qemu-devel>`_
* #qemu on irc.oftc.net

Information on additional methods of contacting the community can be
found online via the QEMU website:

* `<https://wiki.qemu.org/Contribute/StartHere>`_