qemu-e2k/backends
Markus Armbruster 65cd9064e1 qom: Clean up fragile use of error_is_set() in set() methods
Using error_is_set(ERRP) to find out whether a function failed is
either wrong, fragile, or unnecessarily opaque.  It's wrong when ERRP
may be null, because errors go undetected when it is.  It's fragile
when proving ERRP non-null involves a non-local argument.  Else, it's
unnecessarily opaque (see commit 84d18f0).

I guess the error_is_set(errp) in the ObjectProperty set() methods are
merely fragile right now, because I can't find a call chain that
passes a null errp argument.

Make the code more robust and more obviously correct: receive the
error in a local variable, then propagate it through the parameter.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
2014-05-05 19:08:49 +02:00
..
Makefile.objs QOM-ify the TPM support 2013-04-02 08:15:18 -05:00
baum.c backends/baum.c: Fix compilation when SDL is not available. 2014-03-24 17:47:29 +00:00
msmouse.c qemu-char: don't issue CHR_EVENT_OPEN in a BH 2013-06-10 11:38:37 -05:00
rng-egd.c rng-egd: offset the point when repeatedly read from the buffer 2013-11-21 07:55:37 -08:00
rng-random.c rng: initialize file descriptor to -1 2014-01-06 13:45:46 -05:00
rng.c qom: Clean up fragile use of error_is_set() in set() methods 2014-05-05 19:08:49 +02:00
tpm.c qom: Clean up fragile use of error_is_set() in set() methods 2014-05-05 19:08:49 +02:00