99ba777e53
In addition to the qdev_create() patterns converted so far, we have a
qdev_set_parent_bus() pattern. Mostly when we embed a device in a
parent device rather than allocating it on the heap.
This pattern also puts devices in the dangerous "no QOM parent, but
plugged into bus" state I explained in recent commit "qdev: New
qdev_new(), qdev_realize(), etc."
Apply same solution: convert to qdev_realize(). Coccinelle script:
@@
expression dev, bus, errp;
symbol true;
@@
- qdev_set_parent_bus(DEVICE(dev), bus);
...
- object_property_set_bool(OBJECT(dev), true, "realized", errp);
+ qdev_realize(DEVICE(dev), bus, errp);
@ depends on !(file in "qdev-monitor.c") && !(file in "hw/core/qdev.c")@
expression dev, bus, errp;
symbol true;
@@
- qdev_set_parent_bus(dev, bus);
...
- object_property_set_bool(OBJECT(dev), true, "realized", errp);
+ qdev_realize(dev, bus, errp);
@@
expression dev, bus;
symbol true;
@@
- qdev_set_parent_bus(DEVICE(dev), bus);
...
- qdev_init_nofail(DEVICE(dev));
+ qdev_realize(DEVICE(dev), bus, &error_fatal);
Unconverted uses of qdev_set_parent_bus() remain. They'll be
converted later in this series.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-12-armbru@redhat.com>
[Also convert new hw/virtio/vhost-user-vsock-pci.c]
109 lines
3.2 KiB
C
109 lines
3.2 KiB
C
/*
|
|
* Virtio scsi PCI Bindings
|
|
*
|
|
* Copyright IBM, Corp. 2007
|
|
* Copyright (c) 2009 CodeSourcery
|
|
*
|
|
* Authors:
|
|
* Anthony Liguori <aliguori@us.ibm.com>
|
|
* Paul Brook <paul@codesourcery.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or
|
|
* (at your option) any later version. See the COPYING file in the
|
|
* top-level directory.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
|
|
#include "hw/qdev-properties.h"
|
|
#include "hw/virtio/virtio-scsi.h"
|
|
#include "qemu/module.h"
|
|
#include "virtio-pci.h"
|
|
|
|
typedef struct VirtIOSCSIPCI VirtIOSCSIPCI;
|
|
|
|
/*
|
|
* virtio-scsi-pci: This extends VirtioPCIProxy.
|
|
*/
|
|
#define TYPE_VIRTIO_SCSI_PCI "virtio-scsi-pci-base"
|
|
#define VIRTIO_SCSI_PCI(obj) \
|
|
OBJECT_CHECK(VirtIOSCSIPCI, (obj), TYPE_VIRTIO_SCSI_PCI)
|
|
|
|
struct VirtIOSCSIPCI {
|
|
VirtIOPCIProxy parent_obj;
|
|
VirtIOSCSI vdev;
|
|
};
|
|
|
|
static Property virtio_scsi_pci_properties[] = {
|
|
DEFINE_PROP_BIT("ioeventfd", VirtIOPCIProxy, flags,
|
|
VIRTIO_PCI_FLAG_USE_IOEVENTFD_BIT, true),
|
|
DEFINE_PROP_UINT32("vectors", VirtIOPCIProxy, nvectors,
|
|
DEV_NVECTORS_UNSPECIFIED),
|
|
DEFINE_PROP_END_OF_LIST(),
|
|
};
|
|
|
|
static void virtio_scsi_pci_realize(VirtIOPCIProxy *vpci_dev, Error **errp)
|
|
{
|
|
VirtIOSCSIPCI *dev = VIRTIO_SCSI_PCI(vpci_dev);
|
|
DeviceState *vdev = DEVICE(&dev->vdev);
|
|
VirtIOSCSICommon *vs = VIRTIO_SCSI_COMMON(vdev);
|
|
DeviceState *proxy = DEVICE(vpci_dev);
|
|
char *bus_name;
|
|
|
|
if (vpci_dev->nvectors == DEV_NVECTORS_UNSPECIFIED) {
|
|
vpci_dev->nvectors = vs->conf.num_queues + 3;
|
|
}
|
|
|
|
/*
|
|
* For command line compatibility, this sets the virtio-scsi-device bus
|
|
* name as before.
|
|
*/
|
|
if (proxy->id) {
|
|
bus_name = g_strdup_printf("%s.0", proxy->id);
|
|
virtio_device_set_child_bus_name(VIRTIO_DEVICE(vdev), bus_name);
|
|
g_free(bus_name);
|
|
}
|
|
|
|
qdev_realize(vdev, BUS(&vpci_dev->bus), errp);
|
|
}
|
|
|
|
static void virtio_scsi_pci_class_init(ObjectClass *klass, void *data)
|
|
{
|
|
DeviceClass *dc = DEVICE_CLASS(klass);
|
|
VirtioPCIClass *k = VIRTIO_PCI_CLASS(klass);
|
|
PCIDeviceClass *pcidev_k = PCI_DEVICE_CLASS(klass);
|
|
|
|
k->realize = virtio_scsi_pci_realize;
|
|
set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
|
|
device_class_set_props(dc, virtio_scsi_pci_properties);
|
|
pcidev_k->vendor_id = PCI_VENDOR_ID_REDHAT_QUMRANET;
|
|
pcidev_k->device_id = PCI_DEVICE_ID_VIRTIO_SCSI;
|
|
pcidev_k->revision = 0x00;
|
|
pcidev_k->class_id = PCI_CLASS_STORAGE_SCSI;
|
|
}
|
|
|
|
static void virtio_scsi_pci_instance_init(Object *obj)
|
|
{
|
|
VirtIOSCSIPCI *dev = VIRTIO_SCSI_PCI(obj);
|
|
|
|
virtio_instance_init_common(obj, &dev->vdev, sizeof(dev->vdev),
|
|
TYPE_VIRTIO_SCSI);
|
|
}
|
|
|
|
static const VirtioPCIDeviceTypeInfo virtio_scsi_pci_info = {
|
|
.base_name = TYPE_VIRTIO_SCSI_PCI,
|
|
.generic_name = "virtio-scsi-pci",
|
|
.transitional_name = "virtio-scsi-pci-transitional",
|
|
.non_transitional_name = "virtio-scsi-pci-non-transitional",
|
|
.instance_size = sizeof(VirtIOSCSIPCI),
|
|
.instance_init = virtio_scsi_pci_instance_init,
|
|
.class_init = virtio_scsi_pci_class_init,
|
|
};
|
|
|
|
static void virtio_scsi_pci_register(void)
|
|
{
|
|
virtio_pci_types_register(&virtio_scsi_pci_info);
|
|
}
|
|
|
|
type_init(virtio_scsi_pci_register)
|