Jason Baron
266ca11a04
qdev: release parent properties on dc->init failure ...
While looking into hot-plugging bridges, I can create a qemu segfault via:
$ device_add pci-bridge
Bridge chassis not specified. Each bridge is required to be assigned a unique chassis id > 0.
**
ERROR:qom/object.c:389:object_delete: assertion failed: (obj->ref == 0)
I'm proposing to fix this by adding a call to 'object_unparent()', before the
call to qdev_free(). I see there is already a precedent for this usage pattern as
seen in qdev_simple_unplug_cb():
/* can be used as ->unplug() callback for the simple cases */
int qdev_simple_unplug_cb(DeviceState *dev)
{
/* just zap it */
object_unparent(OBJECT(dev));
qdev_free(dev);
return 0;
}
Signed-off-by: Jason Baron <jbaron@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
2012-06-11 22:55:13 +03:00
2012-06-07 17:19:00 +03:00
2012-05-16 18:04:45 -03:00
2012-05-14 10:07:23 -05:00
2012-04-13 12:29:03 +00:00
2012-04-13 12:29:03 +00:00
2012-05-07 16:31:40 +04:00
2012-05-29 20:19:24 -05:00
2012-05-12 09:49:19 +00:00
2012-05-16 18:04:44 -03:00
2012-04-13 12:29:04 +00:00
2012-04-13 12:29:04 +00:00
2012-04-20 15:38:52 +00:00
2012-04-13 12:29:04 +00:00
2012-04-25 10:53:47 +03:00
2012-04-25 10:53:48 +03:00
2012-04-25 10:53:47 +03:00
2012-05-24 02:03:30 +04:00
2012-04-13 11:39:06 +00:00
2012-04-13 11:39:06 +00:00
2012-04-13 12:29:03 +00:00
2012-04-13 11:39:06 +00:00
2012-04-13 11:39:06 +00:00
2012-04-13 11:39:06 +00:00
2012-05-25 18:21:12 +02:00
2012-04-26 12:54:17 +04:00
2012-04-27 11:06:18 +00:00
2012-04-28 20:51:40 +02:00
2012-04-28 20:51:40 +02:00
2012-06-07 17:19:00 +03:00
2012-06-07 17:19:00 +03:00
2012-04-28 20:51:54 +02:00
2012-06-07 17:19:00 +03:00
2012-05-21 15:40:50 -05:00
2012-05-21 15:40:50 -05:00
2012-04-05 14:54:39 +02:00
2012-04-23 17:01:04 +00:00
2012-05-13 19:58:23 +02:00
2012-06-07 17:19:01 +03:00
2012-05-16 18:04:44 -03:00
2012-06-07 17:19:01 +03:00
2012-05-21 19:22:50 +03:00
2012-05-29 20:19:24 -05:00
2012-06-03 07:56:23 +08:00
2012-05-03 07:04:48 +02:00
2012-06-03 07:56:23 +08:00
2012-06-07 17:19:00 +03:00
2012-06-07 17:19:00 +03:00
2012-04-15 12:17:23 +03:00
2012-04-09 14:35:25 -03:00
2012-06-07 17:19:00 +03:00
2012-05-21 19:22:49 +03:00
2012-04-16 15:41:28 +02:00
2012-04-16 15:41:28 +02:00
2012-04-10 12:35:43 +02:00
2012-04-20 13:14:53 +01:00
2012-04-11 13:19:32 +03:00
2012-04-07 14:00:45 +00:00
2012-04-30 17:15:59 +02:00
2012-04-07 14:00:45 +00:00
2012-05-01 21:47:01 +02:00
2012-04-30 17:15:59 +02:00
2012-04-07 14:00:45 +00:00
2012-04-12 11:14:29 +01:00
2012-04-24 09:50:31 -05:00
2012-05-14 10:15:52 -05:00
2012-05-21 15:40:51 -05:00
2012-06-11 22:55:13 +03:00
2012-04-10 08:17:36 -05:00
2012-05-03 10:45:04 +02:00
2012-05-03 10:45:04 +02:00
2012-05-14 10:22:18 +02:00
2012-05-03 10:45:04 +02:00
2012-04-13 12:29:03 +00:00
2012-04-20 15:38:52 +00:00
2012-06-07 17:18:58 +03:00
2012-05-21 15:40:50 -05:00
2012-05-21 15:40:50 -05:00
2012-05-01 21:04:06 +02:00
2012-05-25 13:00:27 +02:00
2012-05-07 08:44:21 +02:00
2012-05-07 08:44:21 +02:00
2012-04-02 09:43:17 -05:00
2012-06-07 17:18:58 +03:00
2012-05-01 21:47:00 +02:00
2012-05-01 21:47:00 +02:00
2012-05-01 21:47:00 +02:00
2012-05-01 21:47:00 +02:00
2012-04-15 17:07:19 +02:00
2012-05-01 21:47:00 +02:00
2012-05-01 21:47:00 +02:00
2012-05-01 21:47:00 +02:00
2012-05-01 21:47:00 +02:00
2012-05-01 21:47:00 +02:00
2012-04-15 17:07:19 +02:00
2012-04-07 14:00:45 +00:00
2012-05-19 15:39:04 +00:00
2012-04-17 10:23:21 +02:00
2012-04-20 15:38:52 +00:00
2012-04-20 15:39:05 +00:00
2012-05-29 20:19:24 -05:00
2012-05-29 20:19:24 -05:00
2012-04-11 13:19:32 +03:00
2012-05-21 15:40:50 -05:00
2012-05-30 14:51:04 +02:00
2012-05-21 15:40:50 -05:00
2012-05-21 15:40:50 -05:00
2012-06-07 17:19:00 +03:00
2012-06-03 07:56:23 +08:00
2012-05-21 15:40:50 -05:00
2012-05-21 15:40:50 -05:00
2012-04-25 10:53:47 +03:00
2012-05-21 15:40:50 -05:00
2012-05-16 18:04:44 -03:00
2012-04-13 17:34:26 +00:00
2012-05-17 10:52:38 +00:00
2012-05-17 10:43:33 +00:00
2012-05-21 15:40:51 -05:00
2012-05-16 18:04:44 -03:00
2012-06-07 17:19:00 +03:00
2012-06-07 17:19:00 +03:00
266ca11a04