qemu-e2k/dump
Markus Armbruster 28035bed1c dump: Improve some dump-guest-memory error messages
Zero @length is rejected with "Invalid parameter 'length'".  Improve
to "parameter 'length' expects a non-zero length".

qemu_open_old() is a wrapper around qemu_open_internal() that throws
away error information.  Switch to the wrapper that doesn't:
qemu_create().  Example improvement:

    (qemu) dump-guest-memory /dev/fdset/x 0 1
    Error: Could not open '/dev/fdset/x': Invalid argument

becomes

    Error: Could not parse fdset /dev/fdset/x

@protocol values not starting with "fd:" or "file:" are rejected with
"Invalid parameter 'protocol'".  Improve to "parameter 'protocol' must
start with 'file:' or 'fd:'".

While there, make the conditional checking @protocol a little more
obvious.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20231031104531.3169721-5-armbru@redhat.com>
2023-11-02 18:40:50 +04:00
..
dump-hmp-cmds.c dump: Add command interface for kdump-raw formats 2023-11-02 18:40:37 +04:00
dump.c dump: Improve some dump-guest-memory error messages 2023-11-02 18:40:50 +04:00
meson.build meson: Replace softmmu_ss -> system_ss 2023-06-20 10:01:30 +02:00
win_dump.c *: Add missing includes of qemu/error-report.h 2023-03-22 15:06:57 +00:00
win_dump.h dump: Simplify compiling win_dump.o by introducing win_dump_available() 2023-02-27 22:29:02 +01:00