80c710cb06
is_valid_option_list()'s purpose is ensuring qemu-img.c's can safely
join multiple parameter strings separated by ',' like this:
g_strdup_printf("%s,%s", params1, params2);
How it does that is anything but obvious. A close reading of the code
reveals that it fails exactly when its argument starts with ',' or
ends with an odd number of ','. Makes sense, actually, because when
the argument starts with ',', a separating ',' preceding it would get
escaped, and when it ends with an odd number of ',', a separating ','
following it would get escaped.
Move it to qemu-img.c and rewrite it the obvious way.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200415074927.19897-9-armbru@redhat.com>
|
||
|---|---|---|
| .. | ||
| atomic128.h | ||
| atomic.h | ||
| base64.h | ||
| bcd.h | ||
| bitmap.h | ||
| bitops.h | ||
| bswap.h | ||
| buffer.h | ||
| co-shared-resource.h | ||
| compiler.h | ||
| config-file.h | ||
| coroutine_int.h | ||
| coroutine.h | ||
| cpuid.h | ||
| crc32c.h | ||
| ctype.h | ||
| cutils.h | ||
| dbus.h | ||
| drm.h | ||
| envlist.h | ||
| error-report.h | ||
| event_notifier.h | ||
| fifo8.h | ||
| fifo32.h | ||
| filemonitor.h | ||
| futex.h | ||
| guest-random.h | ||
| hbitmap.h | ||
| help_option.h | ||
| host-utils.h | ||
| id.h | ||
| int128.h | ||
| iov.h | ||
| iova-tree.h | ||
| jhash.h | ||
| job.h | ||
| lockable.h | ||
| log-for-trace.h | ||
| log.h | ||
| main-loop.h | ||
| memfd.h | ||
| mmap-alloc.h | ||
| module.h | ||
| notify.h | ||
| nvdimm-utils.h | ||
| option_int.h | ||
| option.h | ||
| osdep.h | ||
| path.h | ||
| plugin-memory.h | ||
| plugin.h | ||
| pmem.h | ||
| processor.h | ||
| progress_meter.h | ||
| qdist.h | ||
| qemu-plugin.h | ||
| qemu-print.h | ||
| qht.h | ||
| qsp.h | ||
| queue.h | ||
| range.h | ||
| ratelimit.h | ||
| rcu_queue.h | ||
| rcu.h | ||
| readline.h | ||
| selfmap.h | ||
| seqlock.h | ||
| sockets.h | ||
| stats64.h | ||
| sys_membarrier.h | ||
| systemd.h | ||
| thread-posix.h | ||
| thread-win32.h | ||
| thread.h | ||
| throttle-options.h | ||
| throttle.h | ||
| timed-average.h | ||
| timer.h | ||
| typedefs.h | ||
| unicode.h | ||
| units.h | ||
| uri.h | ||
| uuid.h | ||
| vfio-helpers.h | ||
| win_dump_defs.h | ||
| xattr.h | ||
| xxhash.h | ||