OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity
2cdff7f620
qemu-e2k/block
History
Stefan Hajnoczi 2cdff7f620 linux-aio: avoid deadlock in nested aio_poll() calls 
If two Linux AIO request completions are fetched in the same
io_getevents() call, QEMU will deadlock if request A's callback waits
for request B to complete using an aio_poll() loop.  This was reported
to happen with the mirror blockjob.

This patch moves completion processing into a BH and makes it resumable.
Nested event loops can resume completion processing so that request B
will complete and the deadlock will not occur.

Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Ming Lei <ming.lei@canonical.com>
Cc: Marcin Gibuła <m.gibula@beyond.pl>
Reported-by: Marcin Gibuła <m.gibula@beyond.pl>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Tested-by: Marcin Gibuła <m.gibula@beyond.pl>
2014-08-29 15:59:17 +01:00
..
archipelago.c block: Use g_new() & friends where that makes obvious sense 2014-08-20 11:51:28 +02:00
backup.c block/backup: Fix hang for unaligned image size 2014-07-09 15:50:11 +02:00
blkdebug.c blkdebug: Delete BH in bdrv_aio_cancel 2014-08-22 11:07:00 +02:00
blkverify.c blkverify: Implement bdrv_refresh_filename() 2014-08-20 14:31:56 +02:00
bochs.c block: Use g_new() & friends to avoid multiplying sizes 2014-08-20 11:51:28 +02:00
cloop.c cloop: Handle failure for potentially large allocations 2014-08-15 15:07:15 +02:00
commit.c block: extend block-commit to accept a string for the backing file 2014-07-01 10:47:01 +02:00
cow.c block/cow: Avoid use of uninitialized cow_bs in error path 2014-07-01 10:15:34 +02:00
curl.c block.curl: adding 'timeout' option 2014-08-29 10:46:57 +01:00
dmg.c dmg: Handle failure for potentially large allocations 2014-08-15 15:07:15 +02:00
gluster.c block: Use g_new() & friends where that makes obvious sense 2014-08-20 11:51:28 +02:00
iscsi.c block/iscsi: fix memory corruption on iscsi resize 2014-08-22 10:55:22 +02:00
linux-aio.c linux-aio: avoid deadlock in nested aio_poll() calls 2014-08-29 15:59:17 +01:00
Makefile.objs aio-win32: add support for sockets 2014-08-29 10:46:58 +01:00
mirror.c mirror: fix uninitialized variable delay_ns warnings 2014-08-28 13:42:25 +01:00
nbd-client.c nbd: implement .bdrv_detach/attach_aio_context() 2014-06-04 09:56:11 +02:00
nbd-client.h nbd: implement .bdrv_detach/attach_aio_context() 2014-06-04 09:56:11 +02:00
nbd.c nbd: Implement bdrv_refresh_filename() 2014-08-20 14:31:56 +02:00
nfs.c block: Use g_new() & friends where that makes obvious sense 2014-08-20 11:51:28 +02:00
parallels.c block: Use g_new() & friends to avoid multiplying sizes 2014-08-20 11:51:28 +02:00
qapi.c qemu-img info: show nocow info 2014-08-15 15:07:14 +02:00
qcow2-cache.c qcow2: Use g_try_new0() for cache array 2014-08-20 11:51:28 +02:00
qcow2-cluster.c block: Use g_new() & friends where that makes obvious sense 2014-08-20 11:51:28 +02:00
qcow2-refcount.c block: Use g_new() & friends where that makes obvious sense 2014-08-20 11:51:28 +02:00
qcow2-snapshot.c block: Use g_new() & friends where that makes obvious sense 2014-08-20 11:51:28 +02:00
qcow2.c qcow2: Add runtime options for cache sizes 2014-08-20 11:51:28 +02:00
qcow2.h qcow2: Add runtime options for cache sizes 2014-08-20 11:51:28 +02:00
qcow.c block: Use g_new() & friends where that makes obvious sense 2014-08-20 11:51:28 +02:00
qed-check.c block: Use g_new() & friends to avoid multiplying sizes 2014-08-20 11:51:28 +02:00
qed-cluster.c
qed-gencb.c
qed-l2-cache.c
qed-table.c qed: use BlockDriverState's AioContext 2014-06-04 09:56:11 +02:00
qed.c qed: Handle failure for potentially large allocations 2014-08-15 15:07:15 +02:00
qed.h qed: Make qiov match request size until backing file EOF 2014-07-14 12:03:20 +02:00
quorum.c block/quorum: add simple read pattern support 2014-08-29 10:46:58 +01:00
raw_bsd.c block: Add Error argument to bdrv_refresh_limits() 2014-07-18 13:18:43 +01:00
raw-aio.h linux-aio: implement io plug, unplug and flush io queue 2014-07-07 11:05:17 +02:00
raw-posix.c raw-posix: fix O_DIRECT short reads 2014-08-22 11:00:56 +02:00
raw-win32.c cleanup QEMUOptionParameter 2014-06-16 17:23:21 +08:00
rbd.c block: Use g_new() & friends to avoid multiplying sizes 2014-08-20 11:51:28 +02:00
sheepdog.c sheepdog: fix a core dump while do auto-reconnecting 2014-08-29 10:46:58 +01:00
snapshot.c Use error_is_set() only when necessary 2014-02-17 11:57:23 -05:00
ssh.c cleanup QEMUOptionParameter 2014-06-16 17:23:21 +08:00
stream.c block: Add Error argument to bdrv_refresh_limits() 2014-07-18 13:18:43 +01:00
vdi.c block: Use g_new() & friends where that makes obvious sense 2014-08-20 11:51:28 +02:00
vhdx-endian.c block: VHDX endian fixes 2014-08-15 15:07:14 +02:00
vhdx-log.c block: Drop some superfluous casts from void * 2014-08-20 11:51:28 +02:00
vhdx.c block: Use g_new() & friends where that makes obvious sense 2014-08-20 11:51:28 +02:00
vhdx.h block: VHDX endian fixes 2014-08-15 15:07:14 +02:00
vmdk.c vmdk: Use bdrv_nb_sectors() where sectors, not bytes are wanted 2014-08-22 11:10:12 +02:00
vpc.c vpc: Handle failure for potentially large allocations 2014-08-15 15:07:16 +02:00
vvfat.c block/vvfat.c: remove debugging code to reinit stderr if NULL 2014-08-21 10:36:29 +02:00
win32-aio.c raw-win32: Handle failure for potentially large allocations 2014-08-15 15:07:16 +02:00