5b18a6bf44
Our 'file' chardev backend supports both "output from this chardev is written to a file" and "input from this chardev should be read from a file" (except on Windows). However, you can only set up the input file if you're using the QMP interface -- there is no command line syntax to do it. Add command line syntax to allow specifying an input file as well as an output file, using a new 'input-path' suboption. The specific use case I have is that I'd like to be able to feed fuzzer reproducer input into qtest without having to use '-qtest stdio' and put the input onto stdin. Being able to use a file chardev like this: -chardev file,id=repro,path=/dev/null,input-path=repro.txt -qtest chardev:repro means that stdio is free for use by gdb. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Message-Id: <20230413150724.404304-3-peter.maydell@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> [thuth: Replace "input-file=" typo with "input-path="] Signed-off-by: Thomas Huth <thuth@redhat.com>
150 lines
4.2 KiB
C
150 lines
4.2 KiB
C
/*
|
|
* QEMU System Emulator
|
|
*
|
|
* Copyright (c) 2003-2008 Fabrice Bellard
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
* in the Software without restriction, including without limitation the rights
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
* THE SOFTWARE.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "qapi/error.h"
|
|
#include "qemu/module.h"
|
|
#include "qemu/option.h"
|
|
#include "chardev/char.h"
|
|
|
|
#ifdef _WIN32
|
|
#include "chardev/char-win.h"
|
|
#else
|
|
#include "chardev/char-fd.h"
|
|
#endif
|
|
|
|
static void qmp_chardev_open_file(Chardev *chr,
|
|
ChardevBackend *backend,
|
|
bool *be_opened,
|
|
Error **errp)
|
|
{
|
|
ChardevFile *file = backend->u.file.data;
|
|
#ifdef _WIN32
|
|
HANDLE out;
|
|
DWORD accessmode;
|
|
DWORD flags;
|
|
|
|
if (file->in) {
|
|
error_setg(errp, "input file not supported");
|
|
return;
|
|
}
|
|
|
|
if (file->has_append && file->append) {
|
|
/* Append to file if it already exists. */
|
|
accessmode = FILE_GENERIC_WRITE & ~FILE_WRITE_DATA;
|
|
flags = OPEN_ALWAYS;
|
|
} else {
|
|
/* Truncate file if it already exists. */
|
|
accessmode = GENERIC_WRITE;
|
|
flags = CREATE_ALWAYS;
|
|
}
|
|
|
|
out = CreateFile(file->out, accessmode, FILE_SHARE_READ, NULL, flags,
|
|
FILE_ATTRIBUTE_NORMAL, NULL);
|
|
if (out == INVALID_HANDLE_VALUE) {
|
|
error_setg(errp, "open %s failed", file->out);
|
|
return;
|
|
}
|
|
|
|
win_chr_set_file(chr, out, false);
|
|
#else
|
|
int flags, in = -1, out;
|
|
|
|
flags = O_WRONLY | O_CREAT | O_BINARY;
|
|
if (file->has_append && file->append) {
|
|
flags |= O_APPEND;
|
|
} else {
|
|
flags |= O_TRUNC;
|
|
}
|
|
|
|
out = qmp_chardev_open_file_source(file->out, flags, errp);
|
|
if (out < 0) {
|
|
return;
|
|
}
|
|
|
|
if (file->in) {
|
|
flags = O_RDONLY;
|
|
in = qmp_chardev_open_file_source(file->in, flags, errp);
|
|
if (in < 0) {
|
|
qemu_close(out);
|
|
return;
|
|
}
|
|
}
|
|
|
|
qemu_chr_open_fd(chr, in, out);
|
|
#endif
|
|
}
|
|
|
|
static void qemu_chr_parse_file_out(QemuOpts *opts, ChardevBackend *backend,
|
|
Error **errp)
|
|
{
|
|
const char *path = qemu_opt_get(opts, "path");
|
|
const char *inpath = qemu_opt_get(opts, "input-path");
|
|
ChardevFile *file;
|
|
|
|
backend->type = CHARDEV_BACKEND_KIND_FILE;
|
|
if (path == NULL) {
|
|
error_setg(errp, "chardev: file: no filename given");
|
|
return;
|
|
}
|
|
#ifdef _WIN32
|
|
if (inpath) {
|
|
error_setg(errp, "chardev: file: input-path not supported on Windows");
|
|
return;
|
|
}
|
|
#endif
|
|
file = backend->u.file.data = g_new0(ChardevFile, 1);
|
|
qemu_chr_parse_common(opts, qapi_ChardevFile_base(file));
|
|
file->out = g_strdup(path);
|
|
file->in = g_strdup(inpath);
|
|
|
|
file->has_append = true;
|
|
file->append = qemu_opt_get_bool(opts, "append", false);
|
|
}
|
|
|
|
static void char_file_class_init(ObjectClass *oc, void *data)
|
|
{
|
|
ChardevClass *cc = CHARDEV_CLASS(oc);
|
|
|
|
cc->parse = qemu_chr_parse_file_out;
|
|
cc->open = qmp_chardev_open_file;
|
|
}
|
|
|
|
static const TypeInfo char_file_type_info = {
|
|
.name = TYPE_CHARDEV_FILE,
|
|
#ifdef _WIN32
|
|
.parent = TYPE_CHARDEV_WIN,
|
|
#else
|
|
.parent = TYPE_CHARDEV_FD,
|
|
#endif
|
|
.class_init = char_file_class_init,
|
|
};
|
|
|
|
static void register_types(void)
|
|
{
|
|
type_register_static(&char_file_type_info);
|
|
}
|
|
|
|
type_init(register_types);
|