b4ba67d9a7
The usual use model for the libqos PCI functions is to map a specific PCI BAR using qpci_iomap() then pass the returned token into IO accessor functions. This, and the fact that iomap() returns a (void *) which actually contains a PCI space address, kind of suggests that the return value from iomap is supposed to be an opaque token. ..except that the callers expect to be able to add offsets to it. Which also assumes the compiler will support pointer arithmetic on a (void *), and treat it as working with byte offsets. To clarify this situation change iomap() and the IO accessors to take a definitely opaque BAR handle (enforced with a wrapper struct) along with an offset within the BAR. This changes both the functions and all the callers. There were a number of places that checked if iomap() returned non-NULL, and or initialized it to NULL before hand. Since iomap() already assert()s if it fails to map the BAR, these tests were mostly pointless and are removed. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Reviewed-by: Greg Kurz <groug@kaod.org>
18 lines
412 B
C
18 lines
412 B
C
#ifndef LIBQOS_USB_H
|
|
#define LIBQOS_USB_H
|
|
|
|
#include "libqos/pci-pc.h"
|
|
|
|
struct qhc {
|
|
QPCIDevice *dev;
|
|
QPCIBar bar;
|
|
};
|
|
|
|
void qusb_pci_init_one(QPCIBus *pcibus, struct qhc *hc,
|
|
uint32_t devfn, int bar);
|
|
void uhci_port_test(struct qhc *hc, int port, uint16_t expect);
|
|
|
|
void usb_test_hotplug(const char *bus_name, const int port,
|
|
void (*port_check)(void));
|
|
#endif
|