qemu-e2k/migration
Peter Xu bf269906f5 migration: use g_free for ram load bitmap
Buffers allocated with bitmap_new() should be freed with g_free().

Both reported by Coverity:

*** CID 1391300:  API usage errors  (ALLOC_FREE_MISMATCH)
/migration/ram.c: 3517 in ram_dirty_bitmap_reload()
3511          * the last one to sync, we need to notify the main send thread.
3512          */
3513         ram_dirty_bitmap_reload_notify(s);
3514
3515         ret = 0;
3516     out:
>>>     CID 1391300:  API usage errors  (ALLOC_FREE_MISMATCH)
>>>     Calling "free" frees "le_bitmap" using "free" but it should have been freed using "g_free".
3517         free(le_bitmap);
3518         return ret;
3519     }
3520
3521     static int ram_resume_prepare(MigrationState *s, void *opaque)
3522     {

*** CID 1391292:  API usage errors  (ALLOC_FREE_MISMATCH)
/migration/ram.c: 249 in ramblock_recv_bitmap_send()
243          * Mark as an end, in case the middle part is screwed up due to
244          * some "misterious" reason.
245          */
246         qemu_put_be64(file, RAMBLOCK_RECV_BITMAP_ENDING);
247         qemu_fflush(file);
248
>>>     CID 1391292:  API usage errors  (ALLOC_FREE_MISMATCH)
>>>     Calling "free" frees "le_bitmap" using "free" but it should have been freed using "g_free".
249         free(le_bitmap);
250
251         if (qemu_file_get_error(file)) {
252             return qemu_file_get_error(file);
253         }
254

Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Message-Id: <20180525015042.31778-1-peterx@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
2018-05-25 15:29:48 +02:00
..
block-dirty-bitmap.c migration/block-dirty-bitmap: fix memory leak in dirty_bitmap_load_bits 2018-05-04 08:23:26 -05:00
block.c migration/block: compare only read blocks against the rate limiter 2018-03-23 16:45:18 +00:00
block.h
channel.c Migration+TLS: Fix crash due to double cleanup 2018-05-15 22:13:08 +02:00
channel.h migration: Route errors down through migration_channel_connect 2018-02-06 10:55:12 +00:00
colo-comm.c
colo-failover.c Include less of the generated modular QAPI headers 2018-03-02 13:45:50 -06:00
colo.c Include less of the generated modular QAPI headers 2018-03-02 13:45:50 -06:00
exec.c migration: fix exec/fd migrations 2018-05-25 15:29:47 +02:00
exec.h
fd.c migration: fix exec/fd migrations 2018-05-25 15:29:47 +02:00
fd.h
global_state.c
Makefile.objs migration: add postcopy migration of dirty bitmaps 2018-03-13 17:06:09 -04:00
migration.c migration/qmp: add command migrate-pause 2018-05-15 22:12:57 +02:00
migration.h migration: introduce lock for to_dst_file 2018-05-15 22:12:41 +02:00
page_cache.c
page_cache.h
postcopy-ram.c migration: allow fault thread to pause 2018-05-15 20:24:27 +02:00
postcopy-ram.h vhost+postcopy: Wire up POSTCOPY_END notify 2018-03-20 16:40:37 +02:00
qemu-file-channel.c
qemu-file-channel.h
qemu-file.c migration: detect compression and decompression errors 2018-04-25 18:04:08 +01:00
qemu-file.h migration: stop compression to allocate and free memory frequently 2018-04-25 18:04:06 +01:00
qjson.c qobject: Replace qobject_incref/QINCREF qobject_decref/QDECREF 2018-05-04 08:27:53 +02:00
qjson.h
ram.c migration: use g_free for ram load bitmap 2018-05-25 15:29:48 +02:00
ram.h migration: new message MIG_RP_MSG_RECV_BITMAP 2018-05-15 20:56:51 +02:00
rdma.c migration: update index field when delete or qsort RDMALocalBlock 2018-05-15 22:13:08 +02:00
rdma.h
savevm.c qmp/migration: new command migrate-recover 2018-05-15 22:11:45 +02:00
savevm.h migration: introduce SaveVMHandlers.resume_prepare 2018-05-15 20:56:55 +02:00
socket.c migration: let incoming side use thread context 2018-05-15 20:24:27 +02:00
socket.h migration: Export functions to create send channels 2018-05-15 20:24:27 +02:00
tls.c qio: non-default context for TLS handshake 2018-03-06 10:19:07 +00:00
tls.h
trace-events migration: setup ramstate for resume 2018-05-15 20:56:59 +02:00
vmstate-types.c
vmstate.c
xbzrle.c
xbzrle.h