898ba906cc
Resizing while migrating is dangerous and does not work as expected. The whole migration code works with the usable_length of a ram block and does not expect this value to change at random points in time. In the case of postcopy, relying on used_length is racy as soon as the guest is running. Also, when used_length changes we might leave the uffd handler registered for some memory regions, reject valid pages when migrating and fail when sending the recv bitmap to the source. Resizing can be trigger *after* (but not during) a reset in ACPI code by the guest - hw/arm/virt-acpi-build.c:acpi_ram_update() - hw/i386/acpi-build.c:acpi_ram_update() Let's remember the original used_length in a separate variable and use it in relevant postcopy code. Make sure to update it when we resize during precopy, when synchronizing the RAM block sizes with the source. Reviewed-by: Peter Xu <peterx@redhat.com> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Signed-off-by: David Hildenbrand <david@redhat.com> Message-Id: <20210429112708.12291-9-david@redhat.com> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
75 lines
2.4 KiB
C
75 lines
2.4 KiB
C
/*
|
|
* Declarations for cpu physical memory functions
|
|
*
|
|
* Copyright 2011 Red Hat, Inc. and/or its affiliates
|
|
*
|
|
* Authors:
|
|
* Avi Kivity <avi@redhat.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or
|
|
* later. See the COPYING file in the top-level directory.
|
|
*
|
|
*/
|
|
|
|
/*
|
|
* This header is for use by exec.c and memory.c ONLY. Do not include it.
|
|
* The functions declared here will be removed soon.
|
|
*/
|
|
|
|
#ifndef QEMU_EXEC_RAMBLOCK_H
|
|
#define QEMU_EXEC_RAMBLOCK_H
|
|
|
|
#ifndef CONFIG_USER_ONLY
|
|
#include "cpu-common.h"
|
|
|
|
struct RAMBlock {
|
|
struct rcu_head rcu;
|
|
struct MemoryRegion *mr;
|
|
uint8_t *host;
|
|
uint8_t *colo_cache; /* For colo, VM's ram cache */
|
|
ram_addr_t offset;
|
|
ram_addr_t used_length;
|
|
ram_addr_t max_length;
|
|
void (*resized)(const char*, uint64_t length, void *host);
|
|
uint32_t flags;
|
|
/* Protected by iothread lock. */
|
|
char idstr[256];
|
|
/* RCU-enabled, writes protected by the ramlist lock */
|
|
QLIST_ENTRY(RAMBlock) next;
|
|
QLIST_HEAD(, RAMBlockNotifier) ramblock_notifiers;
|
|
int fd;
|
|
size_t page_size;
|
|
/* dirty bitmap used during migration */
|
|
unsigned long *bmap;
|
|
/* bitmap of already received pages in postcopy */
|
|
unsigned long *receivedmap;
|
|
|
|
/*
|
|
* bitmap to track already cleared dirty bitmap. When the bit is
|
|
* set, it means the corresponding memory chunk needs a log-clear.
|
|
* Set this up to non-NULL to enable the capability to postpone
|
|
* and split clearing of dirty bitmap on the remote node (e.g.,
|
|
* KVM). The bitmap will be set only when doing global sync.
|
|
*
|
|
* NOTE: this bitmap is different comparing to the other bitmaps
|
|
* in that one bit can represent multiple guest pages (which is
|
|
* decided by the `clear_bmap_shift' variable below). On
|
|
* destination side, this should always be NULL, and the variable
|
|
* `clear_bmap_shift' is meaningless.
|
|
*/
|
|
unsigned long *clear_bmap;
|
|
uint8_t clear_bmap_shift;
|
|
|
|
/*
|
|
* RAM block length that corresponds to the used_length on the migration
|
|
* source (after RAM block sizes were synchronized). Especially, after
|
|
* starting to run the guest, used_length and postcopy_length can differ.
|
|
* Used to register/unregister uffd handlers and as the size of the received
|
|
* bitmap. Receiving any page beyond this length will bail out, as it
|
|
* could not have been valid on the source.
|
|
*/
|
|
ram_addr_t postcopy_length;
|
|
};
|
|
#endif
|
|
#endif
|