qemu-e2k/include/ui
Gerd Hoffmann 50628d3479 cirrus/vnc: zap bitblit support from console code.
There is a special code path (dpy_gfx_copy) to allow graphic emulation
notify user interface code about bitblit operations carryed out by
guests.  It is supported by cirrus and vnc server.  The intended purpose
is to optimize display scrolls and just send over the scroll op instead
of a full display update.

This is rarely used these days though because modern guests simply don't
use the cirrus blitter any more.  Any linux guest using the cirrus drm
driver doesn't.  Any windows guest newer than winxp doesn't ship with a
cirrus driver any more and thus uses the cirrus as simple framebuffer.

So this code tends to bitrot and bugs can go unnoticed for a long time.
See for example commit "3e10c3e vnc: fix qemu crash because of SIGSEGV"
which fixes a bug lingering in the code for almost a year, added by
commit "c7628bf vnc: only alloc server surface with clients connected".

Also the vnc server will throttle the frame rate in case it figures the
network can't keep up (send buffers are full).  This doesn't work with
dpy_gfx_copy, for any copy operation sent to the vnc client we have to
send all outstanding updates beforehand, otherwise the vnc client might
run the client side blit on outdated data and thereby corrupt the
display.  So this dpy_gfx_copy "optimization" might even make things
worse on slow network links.

Lets kill it once for all.

Oh, and one more reason: Turns out (after writing the patch) we have a
security bug in that code path ...

Fixes: CVE-2016-9603
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Message-id: 1489494419-14340-1-git-send-email-kraxel@redhat.com
2017-03-16 08:58:15 +01:00
..
console.h cirrus/vnc: zap bitblit support from console code. 2017-03-16 08:58:15 +01:00
egl-context.h opengl: add egl-context.[ch] helpers 2015-10-08 10:34:53 +02:00
egl-helpers.h spice: allow to specify drm rendernode 2017-02-20 12:44:32 +01:00
gtk.h gtk-egl: add scanout_disable support 2017-02-27 16:15:29 +01:00
input.h Remove unused function declarations 2016-09-15 15:32:22 +03:00
pixel_ops.h ui: move files to ui/ and include/ui/ 2012-12-19 08:31:30 +01:00
qemu-pixman.h Use scripts/clean-includes to drop redundant qemu/typedefs.h 2016-03-22 22:20:16 +01:00
qemu-spice.h char: rename CharDriverState Chardev 2017-01-27 18:07:59 +01:00
sdl2.h sdl2: add scanout_disable support 2017-02-27 16:15:29 +01:00
shader.h shaders: initialize vertexes once 2015-10-08 10:31:35 +02:00
spice-display.h spice/gl: render DisplaySurface via opengl 2016-09-28 12:49:36 +02:00