Cédric Le Goater 26c0ae5638 vfio/pci: do not set the PCIDevice 'has_rom' attribute ... PCI devices needing a ROM allocate an optional MemoryRegion with pci_add_option_rom(). pci_del_option_rom() does the cleanup when the device is destroyed. The only action taken by this routine is to call vmstate_unregister_ram() which clears the id string of the optional ROM RAMBlock and now, also flags the RAMBlock as non-migratable. This was recently added by commit b895de5027 ("migration: discard non-migratable RAMBlocks"), . VFIO devices do their own loading of the PCI option ROM in vfio_pci_size_rom(). The memory region is switched to an I/O region and the PCI attribute 'has_rom' is set but the RAMBlock of the ROM region is not allocated. When the associated PCI device is deleted, pci_del_option_rom() calls vmstate_unregister_ram() which tries to flag a NULL RAMBlock, leading to a SEGV. It seems that 'has_rom' was set to have memory_region_destroy() called, but since commit 469b046ead ("memory: remove memory_region_destroy") this is not necessary anymore as the MemoryRegion is freed automagically. Remove the PCIDevice 'has_rom' attribute setting in vfio. Fixes: b895de5027 ("migration: discard non-migratable RAMBlocks") Signed-off-by: Cédric Le Goater <clg@kaod.org> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>		2018-07-11 13:43:57 -06:00
..
amd-xgbe.c
calxeda-xgmac.c
ccw.c	vfio-ccw: add force unlimited prefetch property	2018-06-18 10:50:32 +02:00
common.c	iommu: Add IOMMU index argument to notifier APIs	2018-06-15 15:23:34 +01:00
display.c	ui: introduce vfio_display_reset	2018-04-27 11:36:34 +02:00
Makefile.objs
pci-quirks.c	hw/vfio: Use the IEC binary prefix definitions	2018-07-02 15:41:16 +02:00
pci.c	vfio/pci: do not set the PCIDevice 'has_rom' attribute	2018-07-11 13:43:57 -06:00
pci.h	vfio/quirks: Enable ioeventfd quirks to be handled by vfio directly	2018-06-05 08:28:09 -06:00
platform.c	vfio: Include "exec/address-spaces.h" directly in the source file	2018-05-31 19:12:13 +02:00
spapr.c
trace-events	vfio/quirks: Enable ioeventfd quirks to be handled by vfio directly	2018-06-05 08:28:09 -06:00