3e80f6902c
This is the transformation explained in the commit before previous.
Takes care of just one pattern that needs conversion. More to come in
this series.
Coccinelle script:
@ depends on !(file in "hw/arm/highbank.c")@
expression bus, type_name, dev, expr;
@@
- dev = qdev_create(bus, type_name);
+ dev = qdev_new(type_name);
... when != dev = expr
- qdev_init_nofail(dev);
+ qdev_realize_and_unref(dev, bus, &error_fatal);
@@
expression bus, type_name, dev, expr;
identifier DOWN;
@@
- dev = DOWN(qdev_create(bus, type_name));
+ dev = DOWN(qdev_new(type_name));
... when != dev = expr
- qdev_init_nofail(DEVICE(dev));
+ qdev_realize_and_unref(DEVICE(dev), bus, &error_fatal);
@@
expression bus, type_name, expr;
identifier dev;
@@
- DeviceState *dev = qdev_create(bus, type_name);
+ DeviceState *dev = qdev_new(type_name);
... when != dev = expr
- qdev_init_nofail(dev);
+ qdev_realize_and_unref(dev, bus, &error_fatal);
@@
expression bus, type_name, dev, expr, errp;
symbol true;
@@
- dev = qdev_create(bus, type_name);
+ dev = qdev_new(type_name);
... when != dev = expr
- object_property_set_bool(OBJECT(dev), true, "realized", errp);
+ qdev_realize_and_unref(dev, bus, errp);
@@
expression bus, type_name, expr, errp;
identifier dev;
symbol true;
@@
- DeviceState *dev = qdev_create(bus, type_name);
+ DeviceState *dev = qdev_new(type_name);
... when != dev = expr
- object_property_set_bool(OBJECT(dev), true, "realized", errp);
+ qdev_realize_and_unref(dev, bus, errp);
The first rule exempts hw/arm/highbank.c, because it matches along two
control flow paths there, with different @type_name. Covered by the
next commit's manual conversions.
Missing #include "qapi/error.h" added manually.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-10-armbru@redhat.com>
[Conflicts in hw/misc/empty_slot.c and hw/sparc/leon3.c resolved]
80 lines
2.4 KiB
C
80 lines
2.4 KiB
C
/*
|
|
* ARM CMSDK APB UART emulation
|
|
*
|
|
* Copyright (c) 2017 Linaro Limited
|
|
* Written by Peter Maydell
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 or
|
|
* (at your option) any later version.
|
|
*/
|
|
|
|
#ifndef CMSDK_APB_UART_H
|
|
#define CMSDK_APB_UART_H
|
|
|
|
#include "hw/qdev-properties.h"
|
|
#include "hw/sysbus.h"
|
|
#include "chardev/char-fe.h"
|
|
|
|
#define TYPE_CMSDK_APB_UART "cmsdk-apb-uart"
|
|
#define CMSDK_APB_UART(obj) OBJECT_CHECK(CMSDKAPBUART, (obj), \
|
|
TYPE_CMSDK_APB_UART)
|
|
|
|
typedef struct {
|
|
/*< private >*/
|
|
SysBusDevice parent_obj;
|
|
|
|
/*< public >*/
|
|
MemoryRegion iomem;
|
|
CharBackend chr;
|
|
qemu_irq txint;
|
|
qemu_irq rxint;
|
|
qemu_irq txovrint;
|
|
qemu_irq rxovrint;
|
|
qemu_irq uartint;
|
|
guint watch_tag;
|
|
uint32_t pclk_frq;
|
|
|
|
uint32_t state;
|
|
uint32_t ctrl;
|
|
uint32_t intstatus;
|
|
uint32_t bauddiv;
|
|
/* This UART has no FIFO, only a 1-character buffer for each of Tx and Rx */
|
|
uint8_t txbuf;
|
|
uint8_t rxbuf;
|
|
} CMSDKAPBUART;
|
|
|
|
/**
|
|
* cmsdk_apb_uart_create - convenience function to create TYPE_CMSDK_APB_UART
|
|
* @addr: location in system memory to map registers
|
|
* @chr: Chardev backend to connect UART to, or NULL if no backend
|
|
* @pclk_frq: frequency in Hz of the PCLK clock (used for calculating baud rate)
|
|
*/
|
|
static inline DeviceState *cmsdk_apb_uart_create(hwaddr addr,
|
|
qemu_irq txint,
|
|
qemu_irq rxint,
|
|
qemu_irq txovrint,
|
|
qemu_irq rxovrint,
|
|
qemu_irq uartint,
|
|
Chardev *chr,
|
|
uint32_t pclk_frq)
|
|
{
|
|
DeviceState *dev;
|
|
SysBusDevice *s;
|
|
|
|
dev = qdev_new(TYPE_CMSDK_APB_UART);
|
|
s = SYS_BUS_DEVICE(dev);
|
|
qdev_prop_set_chr(dev, "chardev", chr);
|
|
qdev_prop_set_uint32(dev, "pclk-frq", pclk_frq);
|
|
qdev_realize_and_unref(dev, NULL, &error_fatal);
|
|
sysbus_mmio_map(s, 0, addr);
|
|
sysbus_connect_irq(s, 0, txint);
|
|
sysbus_connect_irq(s, 1, rxint);
|
|
sysbus_connect_irq(s, 2, txovrint);
|
|
sysbus_connect_irq(s, 3, rxovrint);
|
|
sysbus_connect_irq(s, 4, uartint);
|
|
return dev;
|
|
}
|
|
|
|
#endif
|