qemu-e2k/include/migration
zhanghailiang 1d2acc3162 migration: re-active images while migration been canceled after inactive them
commit fe904ea824 fixed a case
which migration aborted QEMU because it didn't regain the control
of images while some errors happened.

Actually, there are another two cases can trigger the same error reports:
" bdrv_co_do_pwritev: Assertion `!(bs->open_flags & 0x0800)' failed",

Case 1, codes path:
migration_thread()
    migration_completion()
        bdrv_inactivate_all() ----------------> inactivate images
        qemu_savevm_state_complete_precopy()
            socket_writev_buffer() --------> error because destination fails
                qemu_fflush() ----------------> set error on migration stream
-> qmp_migrate_cancel() ----------------> user cancelled migration concurrently
    -> migrate_set_state() ------------------> set migrate CANCELLIN
    migration_completion() -----------------> go on to fail_invalidate
	if (s->state == MIGRATION_STATUS_ACTIVE) -> Jump this branch

Case 2, codes path:
migration_thread()
    migration_completion()
        bdrv_inactivate_all() ----------------> inactivate images
    migreation_completion() finished
-> qmp_migrate_cancel() ---------------> user cancelled migration concurrently
    qemu_mutex_lock_iothread();
    qemu_bh_schedule (s->cleanup_bh);

As we can see from above, qmp_migrate_cancel can slip in whenever
migration_thread does not hold the global lock. If this happens after
bdrv_inactive_all() been called, the above error reports will appear.

To prevent this, we can call bdrv_invalidate_cache_all() in qmp_migrate_cancel()
directly if we find images become inactive.

Besides, bdrv_invalidate_cache_all() in migration_completion() doesn't have the
protection of big lock, fix it by add the missing qemu_mutex_lock_iothread();

Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
Message-Id: <1485244792-11248-1-git-send-email-zhang.zhanghailiang@huawei.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
2017-01-24 18:00:31 +00:00
..
block.h Clean up header guards that don't match their file name 2016-07-12 16:19:16 +02:00
colo.h COLO: Implement the process of failover for primary VM 2016-10-30 15:17:39 +05:30
cpu.h migration: Add VMSTATE_UINTTL_TEST() 2016-11-23 12:00:48 +11:00
failover.h COLO: Implement the process of failover for primary VM 2016-10-30 15:17:39 +05:30
migration.h migration: re-active images while migration been canceled after inactive them 2017-01-24 18:00:31 +00:00
page_cache.h xbzrle: optimize XBZRLE to decrease the cache misses 2015-01-15 17:49:43 +05:30
postcopy-ram.h Postcopy: Mark nohugepage before discard 2015-11-10 15:00:28 +01:00
qemu-file.h Clean up decorations and whitespace around header guards 2016-07-12 16:20:46 +02:00
qjson.h migration/qjson: Drop gratuitous use of QOM 2016-05-23 14:16:12 +05:30
vmstate.h migration: migrate QTAILQ 2017-01-24 17:54:47 +00:00