b0e624435b
We can assign and verify the address before realizing and trying to plug. reading/writing the address property should never fail for DIMMs, so let's reduce error handling a bit by using &error_abort. Getting access to the memory region now might however fail. So forward errors from get_memory_region() properly. As all memory devices should use the alignment of the underlying memory region for guest physical address asignment, do detection of the alignment in pc_dimm_pre_plug(), but allow pc.c to overwrite the alignment for compatibility handling. Reviewed-by: Eric Auger <eric.auger@redhat.com> Reviewed-by: Igor Mammedov <imammedo@redhat.com> Acked-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: David Hildenbrand <david@redhat.com> Message-Id: <20180801133444.11269-5-david@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
87 lines
2.7 KiB
C
87 lines
2.7 KiB
C
/*
|
|
* PC DIMM device
|
|
*
|
|
* Copyright ProfitBricks GmbH 2012
|
|
* Copyright (C) 2013-2014 Red Hat Inc
|
|
*
|
|
* Authors:
|
|
* Vasilis Liaskovitis <vasilis.liaskovitis@profitbricks.com>
|
|
* Igor Mammedov <imammedo@redhat.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
* See the COPYING file in the top-level directory.
|
|
*
|
|
*/
|
|
|
|
#ifndef QEMU_PC_DIMM_H
|
|
#define QEMU_PC_DIMM_H
|
|
|
|
#include "exec/memory.h"
|
|
#include "sysemu/hostmem.h"
|
|
#include "hw/qdev.h"
|
|
#include "hw/boards.h"
|
|
|
|
#define TYPE_PC_DIMM "pc-dimm"
|
|
#define PC_DIMM(obj) \
|
|
OBJECT_CHECK(PCDIMMDevice, (obj), TYPE_PC_DIMM)
|
|
#define PC_DIMM_CLASS(oc) \
|
|
OBJECT_CLASS_CHECK(PCDIMMDeviceClass, (oc), TYPE_PC_DIMM)
|
|
#define PC_DIMM_GET_CLASS(obj) \
|
|
OBJECT_GET_CLASS(PCDIMMDeviceClass, (obj), TYPE_PC_DIMM)
|
|
|
|
#define PC_DIMM_ADDR_PROP "addr"
|
|
#define PC_DIMM_SLOT_PROP "slot"
|
|
#define PC_DIMM_NODE_PROP "node"
|
|
#define PC_DIMM_SIZE_PROP "size"
|
|
#define PC_DIMM_MEMDEV_PROP "memdev"
|
|
|
|
#define PC_DIMM_UNASSIGNED_SLOT -1
|
|
|
|
/**
|
|
* PCDIMMDevice:
|
|
* @addr: starting guest physical address, where @PCDIMMDevice is mapped.
|
|
* Default value: 0, means that address is auto-allocated.
|
|
* @node: numa node to which @PCDIMMDevice is attached.
|
|
* @slot: slot number into which @PCDIMMDevice is plugged in.
|
|
* Default value: -1, means that slot is auto-allocated.
|
|
* @hostmem: host memory backend providing memory for @PCDIMMDevice
|
|
*/
|
|
typedef struct PCDIMMDevice {
|
|
/* private */
|
|
DeviceState parent_obj;
|
|
|
|
/* public */
|
|
uint64_t addr;
|
|
uint32_t node;
|
|
int32_t slot;
|
|
HostMemoryBackend *hostmem;
|
|
} PCDIMMDevice;
|
|
|
|
/**
|
|
* PCDIMMDeviceClass:
|
|
* @realize: called after common dimm is realized so that the dimm based
|
|
* devices get the chance to do specified operations.
|
|
* @get_memory_region: returns #MemoryRegion associated with @dimm which
|
|
* is directly mapped into the physical address space of guest. Will not
|
|
* fail after the device was realized.
|
|
* @get_vmstate_memory_region: returns #MemoryRegion which indicates the
|
|
* memory of @dimm should be kept during live migration. Will not fail
|
|
* after the device was realized.
|
|
*/
|
|
typedef struct PCDIMMDeviceClass {
|
|
/* private */
|
|
DeviceClass parent_class;
|
|
|
|
/* public */
|
|
void (*realize)(PCDIMMDevice *dimm, Error **errp);
|
|
MemoryRegion *(*get_memory_region)(PCDIMMDevice *dimm, Error **errp);
|
|
MemoryRegion *(*get_vmstate_memory_region)(PCDIMMDevice *dimm,
|
|
Error **errp);
|
|
} PCDIMMDeviceClass;
|
|
|
|
void pc_dimm_pre_plug(DeviceState *dev, MachineState *machine,
|
|
const uint64_t *legacy_align, Error **errp);
|
|
void pc_dimm_plug(DeviceState *dev, MachineState *machine, Error **errp);
|
|
void pc_dimm_unplug(DeviceState *dev, MachineState *machine);
|
|
#endif
|