Kevin Wolf d3c8c67469 block: Skip implicit nodes in query-block/blockstats ... Commits 0db832f and 6cdbceb introduced the automatic insertion of filter nodes above the top layer of mirror and commit block jobs. The assumption made there was that since libvirt doesn't do node-level management of the block layer yet, it shouldn't be affected by added nodes. This is true as far as commands issued by libvirt are concerned. It only uses BlockBackend names to address nodes, so any operations it performs still operate on the root of the tree as intended. However, the assumption breaks down when you consider query commands, which return data for the wrong node now. These commands also return information on some child nodes (bs->file and/or bs->backing), which libvirt does make use of, and which refer to the wrong nodes, too. One of the consequences is that oVirt gets wrong information about the image size and stops the VM in response as long as a mirror or commit job is running: https://bugzilla.redhat.com/show_bug.cgi?id=1470634 This patch fixes the problem by hiding the implicit nodes created automatically by the mirror and commit block jobs in the output of query-block and BlockBackend-based query-blockstats as long as the user doesn't indicate that they are aware of those nodes by providing a node name for them in the QMP command to start the block job. The node-based commands query-named-block-nodes and query-blockstats with query-nodes=true still show all nodes, including implicit ones. This ensures that users that are capable of node-level management can still access the full information; users that only know BlockBackends won't use these commands. Cc: qemu-stable@nongnu.org Signed-off-by: Kevin Wolf <kwolf@redhat.com> Reviewed-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Max Reitz <mreitz@redhat.com> Tested-by: Eric Blake <eblake@redhat.com>		2017-07-24 15:06:04 +02:00
..
accounting.h	block: make accounting thread-safe	2017-06-16 07:55:00 +08:00
aio.h	aio: add missing aio_notify() to aio_enable_external()	2017-05-12 10:36:46 -04:00
block_backup.h	backup: Switch block_backup.h to byte-based	2017-07-10 13:18:06 +02:00
block_int.h	block: Skip implicit nodes in query-block/blockstats	2017-07-24 15:06:04 +02:00
block.h	block: Skip implicit nodes in query-block/blockstats	2017-07-24 15:06:04 +02:00
blockjob_int.h	blockjob: use deferred_to_main_loop to indicate the coroutine has ended	2017-05-24 16:38:51 -04:00
blockjob.h	fix: avoid an infinite loop or a dangling pointer problem in img_commit	2017-06-26 14:54:46 +02:00
dirty-bitmap.h	block: release persistent bitmaps on inactivate	2017-07-11 17:44:59 +02:00
nbd.h	nbd: Implement NBD_INFO_BLOCK_SIZE on client	2017-07-14 12:04:42 +02:00
qapi.h	block/qapi: Use blk_enable_write_cache()	2016-03-30 12:16:02 +02:00
raw-aio.h	linux-aio: share one LinuxAioState within an AioContext	2016-07-18 15:09:31 +01:00
scsi.h	* SCSI scanner support	2016-07-14 13:44:06 +01:00
snapshot.h	include: Clean up includes	2016-02-23 12:43:05 +00:00
thread-pool.h	Clean up decorations and whitespace around header guards	2016-07-12 16:20:46 +02:00
throttle-groups.h	block: Move I/O throttling configuration functions to BlockBackend	2016-05-19 16:45:30 +02:00
write-threshold.h	Use scripts/clean-includes to drop redundant qemu/typedefs.h	2016-03-22 22:20:16 +01:00