cc1b6c5533
The new tpm-crb-test fails on sparc host:
TEST: tests/tpm-crb-test... (pid=230409)
/i386/tpm-crb/test:
Broken pipe
FAIL
GTester: last random seed: R02S29cea50247fe1efa59ee885a26d51a85
(pid=230423)
FAIL: tests/tpm-crb-test
and generates a new clang sanitizer runtime warning:
/home/petmay01/linaro/qemu-for-merges/hw/tpm/tpm_util.h:36:24: runtime
error: load of misaligned address 0x7fdc24c00002 for type 'const
uint32_t' (aka 'const unsigned int'), which requires 4 byte alignment
0x7fdc24c00002: note: pointer points here
<memory cannot be printed>
The sparc architecture does not allow misaligned loads and will
segfault if you try them. For example, this function:
static inline uint32_t tpm_cmd_get_size(const void *b)
{
return be32_to_cpu(*(const uint32_t *)(b + 2));
}
Should read,
return ldl_be_p(b + 2);
As a general rule you can't take an arbitrary pointer into a byte
buffer and try to interpret it as a structure or a pointer to a
larger-than-bytesize-data simply by casting the pointer.
Use this clean up as an opportunity to remove unnecessary temporary
buffers and casts.
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
68 lines
1.8 KiB
C
68 lines
1.8 KiB
C
/*
|
|
* TPM utility functions
|
|
*
|
|
* Copyright (c) 2010 - 2015 IBM Corporation
|
|
* Authors:
|
|
* Stefan Berger <stefanb@us.ibm.com>
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library; if not, see <http://www.gnu.org/licenses/>
|
|
*/
|
|
|
|
#ifndef TPM_TPM_UTIL_H
|
|
#define TPM_TPM_UTIL_H
|
|
|
|
#include "sysemu/tpm.h"
|
|
#include "qemu/bswap.h"
|
|
|
|
void tpm_util_write_fatal_error_response(uint8_t *out, uint32_t out_len);
|
|
|
|
bool tpm_util_is_selftest(const uint8_t *in, uint32_t in_len);
|
|
|
|
int tpm_util_test_tpmdev(int tpm_fd, TPMVersion *tpm_version);
|
|
|
|
static inline uint16_t tpm_cmd_get_tag(const void *b)
|
|
{
|
|
return lduw_be_p(b);
|
|
}
|
|
|
|
static inline uint32_t tpm_cmd_get_size(const void *b)
|
|
{
|
|
return ldl_be_p(b + 2);
|
|
}
|
|
|
|
static inline uint32_t tpm_cmd_get_ordinal(const void *b)
|
|
{
|
|
return ldl_be_p(b + 6);
|
|
}
|
|
|
|
static inline uint32_t tpm_cmd_get_errcode(const void *b)
|
|
{
|
|
return ldl_be_p(b + 6);
|
|
}
|
|
|
|
int tpm_util_get_buffer_size(int tpm_fd, TPMVersion tpm_version,
|
|
size_t *buffersize);
|
|
|
|
#define DEFINE_PROP_TPMBE(_n, _s, _f) \
|
|
DEFINE_PROP(_n, _s, _f, qdev_prop_tpm, TPMBackend *)
|
|
|
|
typedef struct TPMSizedBuffer {
|
|
uint32_t size;
|
|
uint8_t *buffer;
|
|
} TPMSizedBuffer;
|
|
|
|
void tpm_sized_buffer_reset(TPMSizedBuffer *tsb);
|
|
|
|
#endif /* TPM_TPM_UTIL_H */
|