QEMU With E2K User Support
Go to file
Markus Armbruster 51b9b478cc qom: -object error messages lost location, restore it
qemu_opts_foreach() runs its callback with the error location set to
the option's location.  Any errors the callback reports use the
option's location automatically.

Commit 90998d5 moved the actual error reporting from "inside"
qemu_opts_foreach() to after it.  Here's a typical hunk:

	 if (qemu_opts_foreach(qemu_find_opts("object"),
    -                          object_create,
    -                          object_create_initial, NULL)) {
    +                          user_creatable_add_opts_foreach,
    +                          object_create_initial, &err)) {
    +        error_report_err(err);
	     exit(1);
	 }

Before, object_create() reports from within qemu_opts_foreach(), using
the option's location.  Afterwards, we do it after
qemu_opts_foreach(), using whatever location happens to be current
there.  Commonly a "none" location.

This is because Error objects don't have location information.
Problematic.

Reproducer:

    $ qemu-system-x86_64 -nodefaults -display none -object secret,id=foo,foo=bar
    qemu-system-x86_64: Property '.foo' not found

Note no location.  This commit restores it:

    qemu-system-x86_64: -object secret,id=foo,foo=bar: Property '.foo' not found

Note that the qemu_opts_foreach() bug just fixed could mask the bug
here: if the location it leaves dangling hasn't been clobbered, yet,
it's the correct one.

Reported-by: Eric Blake <eblake@redhat.com>
Cc: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <1461767349-15329-4-git-send-email-armbru@redhat.com>
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
[Paragraph on Error added to commit message]
2016-04-28 08:19:36 +02:00
audio util: move declarations out of qemu-common.h 2016-03-22 22:20:17 +01:00
backends hostmem-file: plug a small leak 2016-04-15 17:56:06 +02:00
block mirror: Workaround for unexpected iohandler events during completion 2016-04-22 16:44:09 +02:00
bsd-user bsd-user: Suppress gcc 4.x -Wpointer-sign (included in -Wall) warning 2016-04-05 17:49:41 +01:00
contrib * Log filtering from Alex and Peter 2016-03-24 21:42:40 +00:00
crypto crypto: do an explicit check for nettle pbkdf functions 2016-03-30 14:55:11 +01:00
default-configs hw/gpio: Add the emulation of gpio_key 2016-03-30 17:27:22 +01:00
disas * Log filtering from Alex and Peter 2016-03-24 21:42:40 +00:00
docs fw_cfg: Adopt /opt/RFQDN convention 2016-04-19 16:09:50 +02:00
dtc@65cc4d2748
fpu target-tricore: Add FPU infrastructure 2016-03-23 09:22:48 +01:00
fsdev module: Rename machine_init() to opts_init() 2016-03-16 15:54:23 -03:00
gdb-xml
hw usb/uhci: move pid check 2016-04-25 12:05:05 +01:00
include qom: -object error messages lost location, restore it 2016-04-28 08:19:36 +02:00
io include/qemu/osdep.h: Don't include qapi/error.h 2016-03-22 22:20:15 +01:00
libdecnumber
linux-headers update Linux headers to 4.6 2016-04-05 11:46:52 +02:00
linux-user linux-user: arm: Handle (ignore) EXCP_YIELD in ARM cpu_loop() 2016-04-04 17:33:51 +01:00
migration util: move declarations out of qemu-common.h 2016-03-22 22:20:17 +01:00
nbd nbd: Don't mishandle unaligned client requests 2016-04-22 11:55:35 +01:00
net filter-buffer: fix segfault when starting qemu with status=off property 2016-04-06 09:52:07 +08:00
pc-bios Update OpenBIOS images 2016-04-18 09:38:55 +01:00
pixman@87eea99e44
po Update language files for QEMU 2.6.0 2016-04-19 18:41:25 +01:00
qapi block: add generic full disk encryption driver 2016-03-30 12:11:26 +02:00
qga qga: Workaround for console redirection from non-interactive qemu-ga service 2016-04-07 11:43:54 -05:00
qobject util: move declarations out of qemu-common.h 2016-03-22 22:20:17 +01:00
qom qom: -object error messages lost location, restore it 2016-04-28 08:19:36 +02:00
replay replay: Fix dangling location bug in replay_configure() 2016-04-28 08:19:20 +02:00
roms Update OpenBIOS images 2016-04-18 09:38:55 +01:00
scripts checkpatch: add target_ulong to typelist 2016-04-05 11:46:52 +02:00
slirp wxx: Fix broken TCP networking (regression) 2016-04-15 19:35:17 +02:00
stubs event-notifier: Add "is_external" parameter 2016-04-22 16:43:56 +02:00
target-alpha include/qemu/osdep.h: Don't include qapi/error.h 2016-03-22 22:20:15 +01:00
target-arm target-arm: Make the 64-bit version of VTCR do the migration 2016-04-04 17:33:52 +01:00
target-cris include/qemu/osdep.h: Don't include qapi/error.h 2016-03-22 22:20:15 +01:00
target-i386 event-notifier: Add "is_external" parameter 2016-04-22 16:43:56 +02:00
target-lm32 include/qemu/osdep.h: Don't include qapi/error.h 2016-03-22 22:20:15 +01:00
target-m68k include/qemu/osdep.h: Don't include qapi/error.h 2016-03-22 22:20:15 +01:00
target-microblaze include/qemu/osdep.h: Don't include qapi/error.h 2016-03-22 22:20:15 +01:00
target-mips target-mips: add MAAR, MAARI register 2016-03-30 09:14:00 +01:00
target-moxie include/qemu/osdep.h: Don't include qapi/error.h 2016-03-22 22:20:15 +01:00
target-openrisc include/qemu/osdep.h: Don't include qapi/error.h 2016-03-22 22:20:15 +01:00
target-ppc ppc: Fix migration of the XER register 2016-04-18 15:14:38 +10:00
target-s390x util: move declarations out of qemu-common.h 2016-03-22 22:20:17 +01:00
target-sh4 include/qemu/osdep.h: Don't include qapi/error.h 2016-03-22 22:20:15 +01:00
target-sparc target-sparc: fix Trap Based Address Register behavior for sparc64 2016-04-15 09:30:40 +01:00
target-tilegx include/qemu/osdep.h: Don't include qapi/error.h 2016-03-22 22:20:15 +01:00
target-tricore * Log filtering from Alex and Peter 2016-03-24 21:42:40 +00:00
target-unicore32 include/qemu/osdep.h: Don't include qapi/error.h 2016-03-22 22:20:15 +01:00
target-xtensa include/qemu/osdep.h: Don't include qapi/error.h 2016-03-22 22:20:15 +01:00
tcg tcg: check for CONFIG_DEBUG_TCG instead of NDEBUG 2016-04-21 15:43:20 +01:00
tests iotests: Test case for drive-mirror with unaligned image size 2016-04-20 16:52:55 +02:00
trace trace: do not always call exit() in trace_enable_events 2016-03-31 09:48:59 +01:00
ui input-linux: refine mouse detection 2016-04-13 15:52:28 +02:00
util QemuOpts: Fix qemu_opts_foreach() dangling location regression 2016-04-28 08:18:56 +02:00
.dir-locals.el
.exrc
.gitignore
.gitmodules
.mailmap
.travis.yml .travis.yml: make -j3 2016-04-05 10:08:15 +01:00
accel.c
aio-posix.c aio-posix: Skip external nodes in aio_dispatch 2016-04-22 16:43:59 +02:00
aio-win32.c
arch_init.c util: move declarations out of qemu-common.h 2016-03-22 22:20:17 +01:00
async.c include/qemu/osdep.h: Don't include qapi/error.h 2016-03-22 22:20:15 +01:00
balloon.c
block.c block: Forbid I/O throttling on nodes with multiple parents for 2.6 2016-04-05 09:22:28 +02:00
blockdev-nbd.c nbd: enable use of TLS with nbd-server-start command 2016-02-16 17:17:49 +01:00
blockdev.c block: Forbid I/O throttling on nodes with multiple parents for 2.6 2016-04-05 09:22:28 +02:00
blockjob.c
bootdevice.c include/qemu/osdep.h: Don't include qapi/error.h 2016-03-22 22:20:15 +01:00
bt-host.c
bt-vhci.c
Changelog
CODING_STYLE
configure block/gluster: prevent data loss after i/o error 2016-04-19 12:24:59 -04:00
COPYING
COPYING.LIB
cpu-exec-common.c
cpu-exec.c qemu-log: dfilter-ise exec, out_asm, op and opt_op 2016-03-22 22:20:18 +01:00
cpus.c cpus: don't use atomic_read for vm_clock_warp_start 2016-04-05 11:46:52 +02:00
cputlb.c cputlb: modernise the debug support 2016-03-22 22:20:18 +01:00
device_tree.c include/qemu/osdep.h: Don't include qapi/error.h 2016-03-22 22:20:15 +01:00
device-hotplug.c blockdev: Split monitor reference from BB creation 2016-03-17 15:47:56 +01:00
disas.c
dma-helpers.c
dump.c util: move declarations out of qemu-common.h 2016-03-22 22:20:17 +01:00
exec.c memory: fix segv on qemu_ram_free(block=0x0) 2016-04-05 11:46:52 +02:00
gdbstub.c util: move declarations out of qemu-common.h 2016-03-22 22:20:17 +01:00
HACKING
hmp-commands-info.hx Dump: add hmp command "info dump" 2016-02-22 18:40:28 +01:00
hmp-commands.hx hmp: 'drive_add -n' for creating a node without BB 2016-03-14 16:46:43 +01:00
hmp.c util: move declarations out of qemu-common.h 2016-03-22 22:20:17 +01:00
hmp.h Dump: add hmp command "info dump" 2016-02-22 18:40:28 +01:00
iohandler.c iohandler: Introduce iohandler_get_aio_context 2016-04-22 16:43:42 +02:00
ioport.c
iothread.c
kvm-all.c kvm: add kvm_device_supported() helper function 2016-03-30 17:27:24 +01:00
kvm-stub.c
LICENSE
main-loop.c util: move declarations out of qemu-common.h 2016-03-22 22:20:17 +01:00
MAINTAINERS MAINTAINERS: Avoid using K: for NUMA section 2016-04-21 11:40:57 +01:00
Makefile osdep: add wrappers for socket functions 2016-03-10 17:19:07 +00:00
Makefile.objs crypto: add cryptographic random byte source 2016-03-17 09:49:01 +00:00
Makefile.target
memory_mapping.c include/qemu/osdep.h: Don't include qapi/error.h 2016-03-22 22:20:15 +01:00
memory.c include/qemu/osdep.h: Don't include qapi/error.h 2016-03-22 22:20:15 +01:00
module-common.c
monitor.c arm: qmp: add query-gic-capabilities interface 2016-03-30 17:27:24 +01:00
numa.c qapi: Don't special-case simple union wrappers 2016-03-18 10:29:26 +01:00
os-posix.c util: move declarations out of qemu-common.h 2016-03-22 22:20:17 +01:00
os-win32.c
page_cache.c
qapi-schema.json slirp: Allow disabling IPv4 or IPv6 2016-04-01 17:51:55 +02:00
qdev-monitor.c util: move declarations out of qemu-common.h 2016-03-22 22:20:17 +01:00
qdict-test-data.txt
qemu-bridge-helper.c
qemu-char.c char: ensure all clients are in non-blocking mode 2016-04-05 11:46:52 +02:00
qemu-doc.texi ivshmem: Require master to have ID zero 2016-03-21 21:29:03 +01:00
qemu-ga.texi
qemu-img-cmds.hx qemu-img: allow specifying image as a set of options args 2016-02-22 09:50:04 +01:00
qemu-img.c qom: -object error messages lost location, restore it 2016-04-28 08:19:36 +02:00
qemu-img.texi qemu-img: allow specifying image as a set of options args 2016-02-22 09:50:04 +01:00
qemu-io-cmds.c qemu-io: Support 'aio_write -z' 2016-04-15 17:22:11 +02:00
qemu-io.c qom: -object error messages lost location, restore it 2016-04-28 08:19:36 +02:00
qemu-nbd.c qom: -object error messages lost location, restore it 2016-04-28 08:19:36 +02:00
qemu-nbd.texi qemu-nbd: allow specifying image as a set of options args 2016-02-22 09:50:04 +01:00
qemu-options-wrapper.h
qemu-options.h
qemu-options.hx fw_cfg: Adopt /opt/RFQDN convention 2016-04-19 16:09:50 +02:00
qemu-seccomp.c seccomp: adding sysinfo system call to whitelist 2016-04-16 20:27:44 +02:00
qemu-tech.texi tcg: Rename tcg-target.c to tcg-target.inc.c 2016-02-23 08:30:38 -08:00
qemu-timer.c icount: decouple warp calls 2016-03-15 18:23:45 +01:00
qemu.nsi
qemu.sasl
qjson.c
qmp-commands.hx arm: qmp: add query-gic-capabilities interface 2016-03-30 17:27:24 +01:00
qmp.c util: move declarations out of qemu-common.h 2016-03-22 22:20:17 +01:00
qtest.c include/qemu/osdep.h: Don't include qapi/error.h 2016-03-22 22:20:15 +01:00
README
rules.mak rules: filter out irrelevant files 2016-02-17 16:59:36 +02:00
softmmu_template.h
spice-qemu-char.c qapi: Don't special-case simple union wrappers 2016-03-18 10:29:26 +01:00
tcg-runtime.c
tci.c tci: Fix build regression 2016-04-07 19:01:21 +02:00
thread-pool.c
thunk.c
tpm.c qapi: Don't special-case simple union wrappers 2016-03-18 10:29:26 +01:00
trace-events ui/virtio-gpu: add and use qemu_create_displaysurface_pixman 2016-04-11 12:32:01 +02:00
translate-all.c translate-all: add missing fold of tb_ctx into tcg_ctx 2016-04-08 00:07:56 +02:00
translate-all.h
translate-common.c
user-exec.c
VERSION Update version for v2.6.0-rc3 release 2016-04-21 17:46:50 +01:00
version.rc
vl.c qom: -object error messages lost location, restore it 2016-04-28 08:19:36 +02:00
xen-common-stub.c
xen-common.c
xen-hvm-stub.c
xen-hvm.c
xen-mapcache.c

         QEMU README
         ===========

QEMU is a generic and open source machine & userspace emulator and
virtualizer.

QEMU is capable of emulating a complete machine in software without any
need for hardware virtualization support. By using dynamic translation,
it achieves very good performance. QEMU can also integrate with the Xen
and KVM hypervisors to provide emulated hardware while allowing the
hypervisor to manage the CPU. With hypervisor support, QEMU can achieve
near native performance for CPUs. When QEMU emulates CPUs directly it is
capable of running operating systems made for one machine (e.g. an ARMv7
board) on a different machine (e.g. an x86_64 PC board).

QEMU is also capable of providing userspace API virtualization for Linux
and BSD kernel interfaces. This allows binaries compiled against one
architecture ABI (e.g. the Linux PPC64 ABI) to be run on a host using a
different architecture ABI (e.g. the Linux x86_64 ABI). This does not
involve any hardware emulation, simply CPU and syscall emulation.

QEMU aims to fit into a variety of use cases. It can be invoked directly
by users wishing to have full control over its behaviour and settings.
It also aims to facilitate integration into higher level management
layers, by providing a stable command line interface and monitor API.
It is commonly invoked indirectly via the libvirt library when using
open source applications such as oVirt, OpenStack and virt-manager.

QEMU as a whole is released under the GNU General Public License,
version 2. For full licensing details, consult the LICENSE file.


Building
========

QEMU is multi-platform software intended to be buildable on all modern
Linux platforms, OS-X, Win32 (via the Mingw64 toolchain) and a variety
of other UNIX targets. The simple steps to build QEMU are:

  mkdir build
  cd build
  ../configure
  make

Complete details of the process for building and configuring QEMU for
all supported host platforms can be found in the qemu-tech.html file.
Additional information can also be found online via the QEMU website:

  http://qemu-project.org/Hosts/Linux
  http://qemu-project.org/Hosts/W32


Submitting patches
==================

The QEMU source code is maintained under the GIT version control system.

   git clone git://git.qemu-project.org/qemu.git

When submitting patches, the preferred approach is to use 'git
format-patch' and/or 'git send-email' to format & send the mail to the
qemu-devel@nongnu.org mailing list. All patches submitted must contain
a 'Signed-off-by' line from the author. Patches should follow the
guidelines set out in the HACKING and CODING_STYLE files.

Additional information on submitting patches can be found online via
the QEMU website

  http://qemu-project.org/Contribute/SubmitAPatch
  http://qemu-project.org/Contribute/TrivialPatches


Bug reporting
=============

The QEMU project uses Launchpad as its primary upstream bug tracker. Bugs
found when running code built from QEMU git or upstream released sources
should be reported via:

  https://bugs.launchpad.net/qemu/

If using QEMU via an operating system vendor pre-built binary package, it
is preferable to report bugs to the vendor's own bug tracker first. If
the bug is also known to affect latest upstream code, it can also be
reported via launchpad.

For additional information on bug reporting consult:

  http://qemu-project.org/Contribute/ReportABug


Contact
=======

The QEMU community can be contacted in a number of ways, with the two
main methods being email and IRC

 - qemu-devel@nongnu.org
   http://lists.nongnu.org/mailman/listinfo/qemu-devel
 - #qemu on irc.oftc.net

Information on additional methods of contacting the community can be
found online via the QEMU website:

  http://qemu-project.org/Contribute/StartHere

-- End