e122636562
This extends the migration_set_incoming_channel and
migration_set_outgoing_channel methods so that they
will automatically wrap the QIOChannel in a
QIOChannelTLS instance if TLS credentials are configured
in the migration parameters.
This allows TLS to work for tcp, unix, fd and exec
migration protocols. It does not (currently) work for
RDMA since it does not use these APIs, but it is
unlikely that TLS would be desired with RDMA anyway
since it would degrade the performance to that seen
with TCP defeating the purpose of using RDMA.
On the target host, QEMU would be launched with a set
of TLS credentials for a server endpoint
$ qemu-system-x86_64 -monitor stdio -incoming defer \
-object tls-creds-x509,dir=/home/berrange/security/qemutls,endpoint=server,id=tls0 \
...other args...
To enable incoming TLS migration 2 monitor commands are
then used
(qemu) migrate_set_str_parameter tls-creds tls0
(qemu) migrate_incoming tcp:myhostname:9000
On the source host, QEMU is launched in a similar
manner but using client endpoint credentials
$ qemu-system-x86_64 -monitor stdio \
-object tls-creds-x509,dir=/home/berrange/security/qemutls,endpoint=client,id=tls0 \
...other args...
To enable outgoing TLS migration 2 monitor commands are
then used
(qemu) migrate_set_str_parameter tls-creds tls0
(qemu) migrate tcp:otherhostname:9000
Thanks to earlier improvements to error reporting,
TLS errors can be seen 'info migrate' when doing a
detached migration. For example:
(qemu) info migrate
capabilities: xbzrle: off rdma-pin-all: off auto-converge: off zero-blocks: off compress: off events: off x-postcopy-ram: off
Migration status: failed
total time: 0 milliseconds
error description: TLS handshake failed: The TLS connection was non-properly terminated.
Or
(qemu) info migrate
capabilities: xbzrle: off rdma-pin-all: off auto-converge: off zero-blocks: off compress: off events: off x-postcopy-ram: off
Migration status: failed
total time: 0 milliseconds
error description: Certificate does not match the hostname localhost
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Message-Id: <1461751518-12128-27-git-send-email-berrange@redhat.com>
Signed-off-by: Amit Shah <amit.shah@redhat.com>
73 lines
2.1 KiB
C
73 lines
2.1 KiB
C
/*
|
|
* QEMU live migration
|
|
*
|
|
* Copyright IBM, Corp. 2008
|
|
* Copyright Dell MessageOne 2008
|
|
* Copyright Red Hat, Inc. 2015-2016
|
|
*
|
|
* Authors:
|
|
* Anthony Liguori <aliguori@us.ibm.com>
|
|
* Charles Duffy <charles_duffy@messageone.com>
|
|
* Daniel P. Berrange <berrange@redhat.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2. See
|
|
* the COPYING file in the top-level directory.
|
|
*
|
|
* Contributions after 2012-01-13 are licensed under the terms of the
|
|
* GNU GPL, version 2 or (at your option) any later version.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "qapi/error.h"
|
|
#include "qemu-common.h"
|
|
#include "migration/migration.h"
|
|
#include "io/channel-command.h"
|
|
#include "trace.h"
|
|
|
|
|
|
void exec_start_outgoing_migration(MigrationState *s, const char *command, Error **errp)
|
|
{
|
|
QIOChannel *ioc;
|
|
const char *argv[] = { "/bin/sh", "-c", command, NULL };
|
|
|
|
trace_migration_exec_outgoing(command);
|
|
ioc = QIO_CHANNEL(qio_channel_command_new_spawn(argv,
|
|
O_WRONLY,
|
|
errp));
|
|
if (!ioc) {
|
|
return;
|
|
}
|
|
|
|
migration_set_outgoing_channel(s, ioc, NULL);
|
|
object_unref(OBJECT(ioc));
|
|
}
|
|
|
|
static gboolean exec_accept_incoming_migration(QIOChannel *ioc,
|
|
GIOCondition condition,
|
|
gpointer opaque)
|
|
{
|
|
migration_set_incoming_channel(migrate_get_current(), ioc);
|
|
object_unref(OBJECT(ioc));
|
|
return FALSE; /* unregister */
|
|
}
|
|
|
|
void exec_start_incoming_migration(const char *command, Error **errp)
|
|
{
|
|
QIOChannel *ioc;
|
|
const char *argv[] = { "/bin/sh", "-c", command, NULL };
|
|
|
|
trace_migration_exec_incoming(command);
|
|
ioc = QIO_CHANNEL(qio_channel_command_new_spawn(argv,
|
|
O_RDONLY,
|
|
errp));
|
|
if (!ioc) {
|
|
return;
|
|
}
|
|
|
|
qio_channel_add_watch(ioc,
|
|
G_IO_IN,
|
|
exec_accept_incoming_migration,
|
|
NULL,
|
|
NULL);
|
|
}
|