4ab9a7429b
In query_port() we pass the address of a local pvrdma_port_attr struct to the rdma_query_backend_port() function. Unfortunately, rdma_backend_query_port() wants a pointer to a struct ibv_port_attr, and the two are not the same length. Coverity spotted this (CID 1507146): pvrdma_port_attr is 48 bytes long, and ibv_port_attr is 52 bytes, because it has a few extra fields at the end. Fortunately, all we do with the attrs struct after the call is to read a few specific fields out of it which are all at the same offsets in both structs, so we can simply make the local variable the correct type. This also lets us drop the cast (which should have been a bit of a warning flag that we were doing something wrong here). We do however need to add extra casts for the fields of the struct that are enums: clang will complain about the implicit cast to a different enum type otherwise. Cc: qemu-stable@nongnu.org Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru> |
||
|---|---|---|
| .. | ||
| vmw | ||
| Kconfig | ||
| meson.build | ||
| rdma_backend_defs.h | ||
| rdma_backend.c | ||
| rdma_backend.h | ||
| rdma_rm_defs.h | ||
| rdma_rm.c | ||
| rdma_rm.h | ||
| rdma_utils.c | ||
| rdma_utils.h | ||
| rdma.c | ||
| trace-events | ||
| trace.h | ||