72f0d0bf51
The local_lremovexattr() callback is vulnerable to symlink attacks because it calls lremovexattr() which follows symbolic links in all path elements but the rightmost one. This patch introduces a helper to emulate the non-existing fremovexattrat() function: it is implemented with /proc/self/fd which provides a trusted path that can be safely passed to lremovexattr(). local_lremovexattr() is converted to use this helper and opendir_nofollow(). This partly fixes CVE-2016-9602. Signed-off-by: Greg Kurz <groug@kaod.org> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
110 lines
2.8 KiB
C
110 lines
2.8 KiB
C
/*
|
|
* 9p user. xattr callback
|
|
*
|
|
* Copyright IBM, Corp. 2010
|
|
*
|
|
* Authors:
|
|
* Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2. See
|
|
* the COPYING file in the top-level directory.
|
|
*
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "9p.h"
|
|
#include "fsdev/file-op-9p.h"
|
|
#include "9p-xattr.h"
|
|
|
|
|
|
static ssize_t mp_user_getxattr(FsContext *ctx, const char *path,
|
|
const char *name, void *value, size_t size)
|
|
{
|
|
if (strncmp(name, "user.virtfs.", 12) == 0) {
|
|
/*
|
|
* Don't allow fetch of user.virtfs namesapce
|
|
* in case of mapped security
|
|
*/
|
|
errno = ENOATTR;
|
|
return -1;
|
|
}
|
|
return local_getxattr_nofollow(ctx, path, name, value, size);
|
|
}
|
|
|
|
static ssize_t mp_user_listxattr(FsContext *ctx, const char *path,
|
|
char *name, void *value, size_t size)
|
|
{
|
|
int name_size = strlen(name) + 1;
|
|
if (strncmp(name, "user.virtfs.", 12) == 0) {
|
|
|
|
/* check if it is a mapped posix acl */
|
|
if (strncmp(name, "user.virtfs.system.posix_acl_", 29) == 0) {
|
|
/* adjust the name and size */
|
|
name += 12;
|
|
name_size -= 12;
|
|
} else {
|
|
/*
|
|
* Don't allow fetch of user.virtfs namesapce
|
|
* in case of mapped security
|
|
*/
|
|
return 0;
|
|
}
|
|
}
|
|
if (!value) {
|
|
return name_size;
|
|
}
|
|
|
|
if (size < name_size) {
|
|
errno = ERANGE;
|
|
return -1;
|
|
}
|
|
|
|
/* name_size includes the trailing NUL. */
|
|
memcpy(value, name, name_size);
|
|
return name_size;
|
|
}
|
|
|
|
static int mp_user_setxattr(FsContext *ctx, const char *path, const char *name,
|
|
void *value, size_t size, int flags)
|
|
{
|
|
if (strncmp(name, "user.virtfs.", 12) == 0) {
|
|
/*
|
|
* Don't allow fetch of user.virtfs namesapce
|
|
* in case of mapped security
|
|
*/
|
|
errno = EACCES;
|
|
return -1;
|
|
}
|
|
return local_setxattr_nofollow(ctx, path, name, value, size, flags);
|
|
}
|
|
|
|
static int mp_user_removexattr(FsContext *ctx,
|
|
const char *path, const char *name)
|
|
{
|
|
if (strncmp(name, "user.virtfs.", 12) == 0) {
|
|
/*
|
|
* Don't allow fetch of user.virtfs namesapce
|
|
* in case of mapped security
|
|
*/
|
|
errno = EACCES;
|
|
return -1;
|
|
}
|
|
return local_removexattr_nofollow(ctx, path, name);
|
|
}
|
|
|
|
XattrOperations mapped_user_xattr = {
|
|
.name = "user.",
|
|
.getxattr = mp_user_getxattr,
|
|
.setxattr = mp_user_setxattr,
|
|
.listxattr = mp_user_listxattr,
|
|
.removexattr = mp_user_removexattr,
|
|
};
|
|
|
|
XattrOperations passthrough_user_xattr = {
|
|
.name = "user.",
|
|
.getxattr = pt_getxattr,
|
|
.setxattr = pt_setxattr,
|
|
.listxattr = pt_listxattr,
|
|
.removexattr = pt_removexattr,
|
|
};
|